-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32094 Bump vcpkg versions for 9.8.x #18783
HPCC-32094 Bump vcpkg versions for 9.8.x #18783
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32094 Jirabot Action Result: |
68eb909
to
3214c1c
Compare
@kenrowland @dcamper this is a draft PR for the vcpkg version bump can you take a look at my "fixes"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pcre2 changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JWT and PCRE2 both changes look reasonable.
3214c1c
to
670b6d3
Compare
Switch vcpkg host triplet to match the target triplet (reduces the number of buils items) Signed-off-by: Gordon Smith <[email protected]>
670b6d3
to
7fd4dbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for most of the builds. Testing an issue with documentation builds now. Set of test builds can be found here https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/9585112175/job/26430268005
@GordonSmith this could do with a comment in the jira about why you needed to make the associated changes in our code. |
@rpastrana - this open telemetry version bump looks like it has broken the Jave support, any thoughts? |
@GordonSmith - I see the issues, but I don't think they're related to the cpp otel libraries, we'll investigate this either a github action env issue, or perhaps a dep packaging issue on the hpcc4j side... |
Switch vcpkg host triplet to match the target triplet (reduces the number of buils items)
Type of change:
Checklist:
Smoketest:
Testing: