Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32094 Bump vcpkg versions for 9.8.x #18783

Merged

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jun 19, 2024

Switch vcpkg host triplet to match the target triplet (reduces the number of buils items)

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32094

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR
Changing assignee from: [email protected] to: [email protected]

@GordonSmith GordonSmith force-pushed the HPCC-32094-VCPKG_VERSIONS branch 2 times, most recently from 68eb909 to 3214c1c Compare June 19, 2024 12:46
@GordonSmith
Copy link
Member Author

@kenrowland @dcamper this is a draft PR for the vcpkg version bump can you take a look at my "fixes"?

Copy link
Contributor

@dcamper dcamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pcre2 changes look good.

Copy link
Contributor

@dcamper dcamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JWT and PCRE2 both changes look reasonable.

@GordonSmith GordonSmith force-pushed the HPCC-32094-VCPKG_VERSIONS branch from 3214c1c to 670b6d3 Compare June 19, 2024 13:32
Switch vcpkg host triplet to match the target triplet (reduces the number of buils items)

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-32094-VCPKG_VERSIONS branch from 670b6d3 to 7fd4dbe Compare June 19, 2024 15:53
@GordonSmith GordonSmith marked this pull request as ready for review June 19, 2024 15:53
@GordonSmith GordonSmith requested a review from ghalliday June 19, 2024 15:54
Copy link
Contributor

@Michael-Gardner Michael-Gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for most of the builds. Testing an issue with documentation builds now. Set of test builds can be found here https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/9585112175/job/26430268005

@ghalliday
Copy link
Member

@GordonSmith this could do with a comment in the jira about why you needed to make the associated changes in our code.

@GordonSmith GordonSmith requested a review from rpastrana June 20, 2024 06:07
@GordonSmith
Copy link
Member Author

@rpastrana - this open telemetry version bump looks like it has broken the Jave support, any thoughts?

@ghalliday ghalliday merged commit 962d058 into hpcc-systems:master Jun 20, 2024
102 of 103 checks passed
@rpastrana
Copy link
Member

@rpastrana - this open telemetry version bump looks like it has broken the Jave support, any thoughts?

@GordonSmith - I see the issues, but I don't think they're related to the cpp otel libraries, we'll investigate this either a github action env issue, or perhaps a dep packaging issue on the hpcc4j side...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants