Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31578 ECL Watch v9 fix LZ FileUpload Folder combobox #18508

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Apr 8, 2024

fix issue where the "Folder" combobox would not properly update the value based upon manually typing a custom path

also, fixing a small bug where closing the dialog without uploading, reopening and attempting to upload the same (previously selected) file would not properly open the dialog

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

fix issue where the "Folder" combobox would not properly update the
value based upon manually typing a custom path

also, fixing a small bug where closing the dialog without uploading,
reopening and attempting to upload the same (previously selected) file
would not properly open the dialog

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg requested a review from GordonSmith April 8, 2024 21:14
Copy link

github-actions bot commented Apr 8, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31578

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@GordonSmith GordonSmith merged commit c53ec8e into hpcc-systems:candidate-9.2.x Apr 10, 2024
50 of 52 checks passed
@jeclrsg jeclrsg deleted the hpcc-31578-fileupload-dialog-folder-combobox branch April 22, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants