Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31573 Add Github Action for ESP Regression Suite #18504

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Apr 5, 2024

  • Added HPCC4j ESP regression suite to K8s regression suite

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

- Added HPCC4j ESP regression suite to K8s regression suite

Signed-off-by: James McMullan [email protected]
@jpmcmu jpmcmu requested a review from rpastrana April 5, 2024 19:27
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Apr 5, 2024

@rpastrana please review

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Apr 5, 2024

Example Test Output:

ESP Regression Suite Test Failures:

The following tests failed; checkout a copy of the HPCC4j project with the following command and run the individual test commands below to debug the failures.

git clone https://github.com/BrokenTests.git hpcc4j
cd hpcc4j && git checkout BrokenTests

org.hpccsystems.ws.client.WsDFUClientTest.testGetFiles Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WsDFUClientTest#testGetFiles test

org.hpccsystems.ws.client.WsDFUClientTest.testGetFileContent Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WsDFUClientTest#testGetFileContent test

org.hpccsystems.ws.client.WUQueryTest.testGetWorkunitByAppName Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WUQueryTest#testGetWorkunitByAppName test

org.hpccsystems.ws.client.WSWorkunitsTest.testMultipleWsWUInits Failed

Error: Example error
Test Command: mvn -B -Dhpccconn=https://eclwatch.default:8010 -Dtest=org.hpccsystems.ws.client.WSWorkunitsTest#testMultipleWsWUInits test

Copy link

github-actions bot commented Apr 5, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31573

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu looks good from my end, let's have @GordonSmith and @ghalliday take a peek

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaml looks fine - didn't review the python...

@rpastrana rpastrana requested a review from ghalliday April 9, 2024 19:21
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasaonable

@ghalliday ghalliday merged commit 8009423 into hpcc-systems:candidate-9.4.x Apr 10, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants