From 0b722af738d309f6198cc77677f74c0694c26f0a Mon Sep 17 00:00:00 2001
From: Richard Chapman <rchapman@hpccsystems.com>
Date: Wed, 10 Jan 2024 16:21:56 +0000
Subject: [PATCH] HPCC-31100 ROXIE_ALIVE message may contain some stats

I don't think the stats will get sent, but it will be gathering some, which it probably should not

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
---
 roxie/ccd/ccdqueue.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/roxie/ccd/ccdqueue.cpp b/roxie/ccd/ccdqueue.cpp
index ae63ee222fb..8cfd3565661 100644
--- a/roxie/ccd/ccdqueue.cpp
+++ b/roxie/ccd/ccdqueue.cpp
@@ -2403,6 +2403,7 @@ class RoxieSocketQueueManager : public RoxieReceiverBase
     Owned<TokenBucket> bucket;
     unsigned maxPacketSize = 0;
     std::atomic<bool> running = { false };
+    StringContextLogger logctx;
 #ifdef NEW_IBYTI
     DelayedPacketQueueManager delayed;
 #endif
@@ -2426,7 +2427,7 @@ class RoxieSocketQueueManager : public RoxieReceiverBase
     } readThread;
 
 public:
-    RoxieSocketQueueManager(unsigned _numWorkers) : RoxieReceiverBase(_numWorkers), readThread(*this)
+    RoxieSocketQueueManager(unsigned _numWorkers) : RoxieReceiverBase(_numWorkers), logctx("RoxieSocketQueueManager"), readThread(*this)
     {
         maxPacketSize = multicastSocket->get_max_send_size();
         if ((maxPacketSize==0)||(maxPacketSize>65535))
@@ -2711,7 +2712,6 @@ class RoxieSocketQueueManager : public RoxieReceiverBase
                     if (testAgentFailure & 0x1 && !retries)
                         return;
 #endif
-                    AgentContextLogger logctx(packet);
                     if (doTrace(traceRoxiePackets))
                     {
                         StringBuffer buf;
@@ -2728,7 +2728,6 @@ class RoxieSocketQueueManager : public RoxieReceiverBase
                     if (retries >= SUBCHANNEL_MASK)
                         return; // someone sent a failure or something - ignore it
 
-                    AgentContextLogger logctx(packet);
                     // Send back an out-of-band immediately, to let Roxie server know that channel is still active
                     if (!(testAgentFailure & 0x800) && !acknowledgeAllRequests)
                     {
@@ -3548,11 +3547,10 @@ class RoxieLocalReceiveManager : implements ILocalReceiveManager, public CInterf
 {
     MapXToMyClass<ruid_t, ruid_t, ILocalMessageCollator> collators;
     CriticalSection crit;
-    Owned<StringContextLogger> logctx;
 
 public:
     IMPLEMENT_IINTERFACE;
-    RoxieLocalReceiveManager() : logctx(new StringContextLogger("RoxieLocalReceiveManager"))
+    RoxieLocalReceiveManager()
     {
     }