Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue #54

Open
zhongyuansh opened this issue Jan 25, 2022 · 2 comments
Open

Performance issue #54

zhongyuansh opened this issue Jan 25, 2022 · 2 comments

Comments

@zhongyuansh
Copy link

Hi,

Maybe I found a performance issue of XPMEM.

  1. xpmem_attach use the function "remap_pfn_range" to map page to vma.
  2. But this funtion will split 2M huge page to 4KB page
  3. 4KB TLB miss will increase, this is a performance issue

Is there any way to fix this issue?

@hjelmn
Copy link
Collaborator

hjelmn commented Jun 14, 2022

Not sure. I haven't looked at the implementation of remap_pfn_range to see if it will cause this to happen. If it does, I expect that Cray probably modified their kernel to not split the pages. If huge pages are indeed being split I welcome a fix if someone has one. I probably won't find time to work on this myself anytime soon.

@deantroe
Copy link

It does result in 4kb pages, and Cray does not have any magic to make them remain huge pages. That would be ideal, but last I looked there was no logical path to do that.

tzafrir-mellanox pushed a commit to tzafrir-mellanox/xpmem that referenced this issue Sep 11, 2024
BUILD: Fix various build warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants