-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segmentation painting and MLSD support. #41
Comments
It seems you are using MLSD as a detector, ie. the modules (preprocessors) part of ControlNet, not the models (rendering). The detectors/preprocessors are used to detect features in an image, or do some computations before the image can be used by the models for rendering. Check your http://127.0.0.1:7860/controlnet/model_list URL to find the correct model to add to Once added to the configuration, restart the application and use the shortcut There seems to be a bug with the |
No, no, you misread. MLSD model loaded and worked for me and the detector doesn't seem to do anything, just as you replied. It's all good when it comes to generating images but can't trace them. I guess that's something to solve. Any comment on segmentation painting? Is it doable? |
Ok I was not sure you were using MLSD for the rendering part also. In theory segmentation painting should work, but would necessitate at least a color picker and a paint filler of some kind. It's not something I expect to code anytime soon, but maybe someone will. 😅 Another approach could be to modify the img2img mode to send the image data to ControlNet instead, and use an external editor with the correct editing capabilities. |
The problem was with the default threshold values used. MLSD detector is now working after #47 . |
Would love to see segmentation painting as an added feature. It seems that most of the brush painting groundwork is already done, so it's a matter of figuring out how to use the color presets: https://www.reddit.com/r/StableDiffusion/comments/11e4vxl/paint_by_color_numbers_with_controlnet/
Since this wonderful app can already draw straight lines how about adding MLSD model support?
Good job on the app! Amazing how fast it's developing.
EDIT: Ok, so MLSD model apparently works when you add it to the model list in config.json but MLSD detector doesn't seem to be doing its job. I get a blank canvas when switching to it with an image already generated on the left side. The other detectors show proper results.
The text was updated successfully, but these errors were encountered: