From d1d1b4029115fc13a932fcc46de005319c1ebb70 Mon Sep 17 00:00:00 2001
From: Yash Maheshwari <yashmaheshwari551@gmail.com>
Date: Wed, 4 Dec 2024 12:45:10 +0530
Subject: [PATCH] Fixed: issue with reordering of rules not being saved by
 updating the sequence of rules just after reordering instead of udpating them
 before saving(#283)

---
 src/views/BrokeringQuery.vue | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/src/views/BrokeringQuery.vue b/src/views/BrokeringQuery.vue
index efb5fdf..ee6f9e2 100644
--- a/src/views/BrokeringQuery.vue
+++ b/src/views/BrokeringQuery.vue
@@ -1170,7 +1170,7 @@ function doConditionSortReorder(event: CustomEvent) {
 
 function findRulesDiff(previousSeq: any, updatedSeq: any) {
   const diffSeq: any = Object.keys(previousSeq).reduce((diff, key) => {
-    if (updatedSeq[key].routingRuleId === previousSeq[key].routingRuleId && updatedSeq[key].statusId === previousSeq[key].statusId && updatedSeq[key].assignmentEnumId === previousSeq[key].assignmentEnumId && updatedSeq[key].ruleName === previousSeq[key].ruleName) return diff
+    if (updatedSeq[key].routingRuleId === previousSeq[key].routingRuleId && updatedSeq[key].statusId === previousSeq[key].statusId && updatedSeq[key].assignmentEnumId === previousSeq[key].assignmentEnumId && updatedSeq[key].ruleName === previousSeq[key].ruleName && updatedSeq[key].sequenceNum === previousSeq[key].sequenceNum) return diff
     return {
       ...diff,
       [key]: updatedSeq[key]
@@ -1313,6 +1313,16 @@ function doReorder(event: CustomEvent) {
   diffSeq = Object.keys(diffSeq).map((key) => diffSeq[key])
 
   rulesForReorder.value = updatedSeq
+
+  // Once the reordering is completed then update the original rules array with the updated sequenceNum
+  // This is required as we will find a final diff of rules before saving changes
+  inventoryRules.value.map((rule: Rule) => {
+    const updatedRule = updatedSeq.find((seq: any) => seq.routingRuleId === rule.routingRuleId)
+    if(updatedRule) {
+      rule.sequenceNum = updatedRule.sequenceNum
+    }
+  })
+
   hasUnsavedChanges.value = true
 }
 
@@ -1331,12 +1341,6 @@ async function save() {
   // Find diff for inventory rules
   if(currentRouting.value["rules"]) {
     let diffSeq = findRulesDiff(currentRouting.value["rules"], inventoryRules.value)
-  
-    const updatedSeqenceNum = currentRouting.value["rules"].map((rule: Rule) => rule.sequenceNum)
-    Object.keys(diffSeq).map((key: any) => {
-      diffSeq[key].sequenceNum = updatedSeqenceNum[key]
-    })
-  
     diffSeq = Object.keys(diffSeq).map((key) => diffSeq[key])
   
     if(diffSeq.length) {
@@ -1493,7 +1497,9 @@ function isPartialGroupItemsAllocationActive() {
 }
 
 function initializeInventoryRules() {
-  rulesForReorder.value = JSON.parse(JSON.stringify(getActiveAndDraftOrderRules()))
+  // Sorting the sequence once again here, as after making some changes in the rules like status, enumId etc
+  // the original reordered sequence is lost thus before updating the variable sorting it first and then saving changes
+  rulesForReorder.value = sortSequence(JSON.parse(JSON.stringify(getActiveAndDraftOrderRules())))
 }
 
 function getActiveAndDraftOrderRules() {