From 435d8b7f07fa5d47015b50a2c0b0674eefa5d538 Mon Sep 17 00:00:00 2001 From: Ridwan6947 Date: Sat, 27 Jul 2024 13:33:09 +0530 Subject: [PATCH 1/4] Fixed: Card content is hidden behind the tab-bar (#289) --- src/views/FindFacilities.vue | 6 +++++- src/views/FindGroups.vue | 6 ++++++ src/views/Parking.vue | 6 ++---- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/views/FindFacilities.vue b/src/views/FindFacilities.vue index deb94214..2a8729e5 100644 --- a/src/views/FindFacilities.vue +++ b/src/views/FindFacilities.vue @@ -405,7 +405,11 @@ export default defineComponent({ .list-item { --columns-desktop: 4; } - +@media screen and (min-width: 1000px) { +main { + padding-bottom: 3.5rem; +} +} config-note { display: block; text-align: center; diff --git a/src/views/FindGroups.vue b/src/views/FindGroups.vue index 5ce7e187..a2da832e 100644 --- a/src/views/FindGroups.vue +++ b/src/views/FindGroups.vue @@ -337,4 +337,10 @@ main:has(ion-card) { grid-template-columns: repeat(auto-fill, minmax(500px, 1fr)); align-items: start; } + +@media screen and (min-width: 1000px) { + main { + padding-bottom: 4rem; + } +} \ No newline at end of file diff --git a/src/views/Parking.vue b/src/views/Parking.vue index 80f1d3e3..098a48e4 100644 --- a/src/views/Parking.vue +++ b/src/views/Parking.vue @@ -234,12 +234,10 @@ main { margin: auto; } -@media screen and (min-width: 700px) { - +@media screen and (min-width: 1000px) { main { - padding: var(--spacer-lg); + padding-bottom: 5rem; } - } \ No newline at end of file From 569c2d2a9facadfb6ec51db9e053f50bdcdf26c1 Mon Sep 17 00:00:00 2001 From: Ridwa Date: Mon, 29 Jul 2024 12:44:27 +0530 Subject: [PATCH 2/4] Fixed: fixed tab-bar alignment and indentataion , removed media queries(#289) --- src/views/FindFacilities.vue | 5 ++--- src/views/FindGroups.vue | 7 +++---- src/views/Parking.vue | 6 ++---- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/views/FindFacilities.vue b/src/views/FindFacilities.vue index 2a8729e5..cd9c3795 100644 --- a/src/views/FindFacilities.vue +++ b/src/views/FindFacilities.vue @@ -405,10 +405,9 @@ export default defineComponent({ .list-item { --columns-desktop: 4; } -@media screen and (min-width: 1000px) { + main { - padding-bottom: 3.5rem; -} + padding-bottom: 80px; } config-note { display: block; diff --git a/src/views/FindGroups.vue b/src/views/FindGroups.vue index a2da832e..9659316c 100644 --- a/src/views/FindGroups.vue +++ b/src/views/FindGroups.vue @@ -338,9 +338,8 @@ main:has(ion-card) { align-items: start; } -@media screen and (min-width: 1000px) { - main { - padding-bottom: 4rem; - } +main { + padding-bottom: 80px; } + \ No newline at end of file diff --git a/src/views/Parking.vue b/src/views/Parking.vue index 098a48e4..0b2296d1 100644 --- a/src/views/Parking.vue +++ b/src/views/Parking.vue @@ -234,10 +234,8 @@ main { margin: auto; } -@media screen and (min-width: 1000px) { - main { - padding-bottom: 5rem; - } +main { + padding-bottom: 80px; } \ No newline at end of file From 2eb1307af79a0014b8b9059c7ffdf0cea191a4da Mon Sep 17 00:00:00 2001 From: Yash Maheshwari Date: Wed, 21 Aug 2024 18:08:23 +0530 Subject: [PATCH 3/4] Fixed: styling to have bottom padding to remove the overlapping of content with tab-bar(#289) --- src/views/FindFacilities.vue | 5 +++-- src/views/Parking.vue | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/views/FindFacilities.vue b/src/views/FindFacilities.vue index cd9c3795..cf6b8536 100644 --- a/src/views/FindFacilities.vue +++ b/src/views/FindFacilities.vue @@ -406,9 +406,10 @@ export default defineComponent({ --columns-desktop: 4; } -main { - padding-bottom: 80px; +ion-content { + --padding-bottom: 80px; } + config-note { display: block; text-align: center; diff --git a/src/views/Parking.vue b/src/views/Parking.vue index 0b2296d1..298631be 100644 --- a/src/views/Parking.vue +++ b/src/views/Parking.vue @@ -234,8 +234,8 @@ main { margin: auto; } -main { - padding-bottom: 80px; +ion-content { + --padding-bottom: 80px; } \ No newline at end of file From 3b1bb16149d4375b8abbf022e2516c5b0cfe6e7d Mon Sep 17 00:00:00 2001 From: Yash Maheshwari Date: Wed, 21 Aug 2024 18:17:38 +0530 Subject: [PATCH 4/4] Added: padding bottom only when having screen size greater than 991px(#289) --- src/views/FindFacilities.vue | 10 ++++++---- src/views/Parking.vue | 6 ++++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/views/FindFacilities.vue b/src/views/FindFacilities.vue index cf6b8536..ecdb521f 100644 --- a/src/views/FindFacilities.vue +++ b/src/views/FindFacilities.vue @@ -406,12 +406,14 @@ export default defineComponent({ --columns-desktop: 4; } -ion-content { - --padding-bottom: 80px; -} - config-note { display: block; text-align: center; } + +@media screen and (min-width: 991px) { + ion-content { + --padding-bottom: 80px; + } +} \ No newline at end of file diff --git a/src/views/Parking.vue b/src/views/Parking.vue index 298631be..1c11873b 100644 --- a/src/views/Parking.vue +++ b/src/views/Parking.vue @@ -234,8 +234,10 @@ main { margin: auto; } -ion-content { - --padding-bottom: 80px; +@media screen and (min-width: 991px) { + ion-content { + --padding-bottom: 80px; + } } \ No newline at end of file