Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Product Store ID Instead of Store Name in facility associated stores list when no store name is present #323

Open
2 tasks
amansinghbais opened this issue Oct 15, 2024 · 5 comments
Assignees
Labels
bug Something isn't working hacktoberfest Good issue for Hacktoberfest event

Comments

@amansinghbais
Copy link
Contributor

Current behavior

Currently, the product store list displays the store name in the list items. However, if the store name is not present, the list item appears empty or incomplete.

Expected behavior

To improve user experience, we should display the product store ID in place of the store name if the name is not available.

Steps to reproduce the issue

  1. Open the facilities details page for any facility.
  2. Add a product store in the facility with no store name.
  3. Observe the empty space where the store name should be.

Screenshot

Screenshot from 2024-10-15 14-47-45

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

@amansinghbais amansinghbais added bug Something isn't working hacktoberfest Good issue for Hacktoberfest event labels Oct 15, 2024
@theabhishekjamle
Copy link
Contributor

hotwax ,

@mustang006
Copy link

i would like to handle this

@ymaheshwari1
Copy link
Contributor

@theabhishekjamle Please go ahead

ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Nov 20, 2024
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Nov 20, 2024
ymaheshwari1 added a commit that referenced this issue Nov 20, 2024
Improved: case to display productStoreId when name for the productStore is missing(#323)
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to ⏸️ Dev complete in Digital Experience Platform Nov 20, 2024
@priyanshee1604
Copy link

priyanshee1604 commented Nov 27, 2024

Same issue exists on the Product Store filter on the Find Facilities Page.
https://jam.dev/c/2ba370bc-5d4b-4155-86be-92aa07ca6d82

@priyanshee1604
Copy link

Successfully tested the issue by creating a ProductStore in ProductStore entity with a productStoreId while leaving the storeName field empty. The application correctly displayed the productStoreId in the absence of a storeName.

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Dec 18, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📅 Planned in Digital Experience Platform Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Good issue for Hacktoberfest event
Projects
Status: 📅 Planned
Development

No branches or pull requests

5 participants