Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When fetching facilities for group, some of the linked facilities are not displayed on UI #322

Open
1 of 2 tasks
ymaheshwari1 opened this issue Oct 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ymaheshwari1
Copy link
Contributor

Current behavior

When checking for linked facilities for a group, the max viewSize returned in results in 250 but if the passed groupIds have more records than 250 then those records are skipped.

Expected behavior

If such a case occurs when the result count exceed 250 then we should again request the records for the same query by passing index.

Steps to reproduce the issue

  • Go to facility group pages and using an instance where we are having 100s of facilities
  • If we have limited facilities associated with groups, then associate facilities with groups so that the overall linked facilities with a batch of 10 groups exceeds 250, and then verify the issue.

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

When having multiple groups we make the query by creating batches of 10 groupIds, and fetch the records, but there are case where a single group is associated with 100 facilities and thus the overall count in some cases exceeds 250, resulting in discrepancies on UI.

@ymaheshwari1 ymaheshwari1 added the bug Something isn't working label Oct 6, 2024
@ymaheshwari1 ymaheshwari1 changed the title When fetching facilities for group, some of the linked facilities are skipped When fetching facilities for group, some of the linked facilities are not displayed on UI Oct 6, 2024
@ymaheshwari1 ymaheshwari1 self-assigned this Oct 6, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Oct 6, 2024
@ravilodhi ravilodhi assigned R-Sourabh and unassigned ymaheshwari1 Oct 15, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Oct 15, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Oct 16, 2024
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Oct 16, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Oct 16, 2024
ymaheshwari1 added a commit that referenced this issue Nov 20, 2024
Improved: Added logic to fetch the facilities for the linked facility group if it exceeds the view size (#322)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ⏸️ Dev complete
Development

No branches or pull requests

2 participants