Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate removal and update of facility latitude/longitude #255

Open
Adameddy26 opened this issue Apr 30, 2024 · 1 comment
Open

Inaccurate removal and update of facility latitude/longitude #255

Adameddy26 opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Adameddy26
Copy link

Cases

Case 1 - Removal Inconsistency
When a user attempts to remove a generated latitude/longitude by clearing the input fields, a toast message displays success, but the values persist. This only occurs for generated coordinates; manually entered values can be removed successfully.

Case 2 - Zero Input Handling
Entering "0" (zero) in both latitude and longitude fields and saving doesn't update the facility details page. However, reopening the edit modal and saving again with "0" in both fields allows the update. This behavior needs correction for a consistent user experience.

Case 3 - Editing Restriction
Users cannot edit existing latitude/longitude values by typing and saving changes within the input fields. This results in an error message.

Expected Behavior

Case 1: Users should be able to remove previously generated latitude/longitude coordinates by clearing the input fields and saving. The toast message should accurately reflect this action.
Case 2&3: The system should prevent saving invalid coordinates like "0" or any other character(except '.' and '-') for both latitude and longitude. Ideally, an error message should prompt the user in this case.

Steps to Reproduce

Login the app with valid user credentials.
On the find facilities page, open the facility details of any facility.

Case 1. Unable to Remove Generated Latitude/Longitude

  • Attempt to remove the generated latitude/longitude.
  • Note that the toast message indicates successful removal, but the values remain unchanged.

Case 2. Handling '0' Inputs in Latitude/Longitude Fields

  • Enter '0' in both the latitude and longitude input fields.
  • Save the changes and observe the latitude/longitude section on the details page not updating.
  • Reopen the modal and attempt to save.
  • Now again type the same values for both the fields i.e. 0 and try to save the changes.

Case 3. Error When Editing Field Values

  • Try to edit and save characters inside longitude and latitude field values.
  • Note the error message preventing successful updates.

Environment details

App environment : UAT
App version : v1.7.0

Additional information

https://jam.dev/c/66947943-b96d-46a0-bbce-c3f0a285b42a

@Adameddy26 Adameddy26 added the bug Something isn't working label Apr 30, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform May 2, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform May 2, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue May 2, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue May 2, 2024
@Adameddy26
Copy link
Author

Adameddy26 commented May 3, 2024

@R-Sourabh Few more points needs to be considered while fixing this issue -

Case A
When latitude/longitude are not generated and user clicks on 'Add' button
1.1. Generate button should appear enabled and If the latitude/longitude is generated successfully, it should get disabled.
1.2. If unable to find the latitude/longitude for types Zip code, generate button should appear enabled.
If latitude/longitude are generated successfully and saved.
1.3 On opening the edit modal, generate button should appear disabled until any changes are made to the Zip code field.
1.4 On entering the same value for which latitude/longitude were generated previously, the button should again get disabled.
On removing the latitude/longitude and opening the modal again
1.5 Behavior should be same as mentioned for 'When latitude/longitude are not generated and user clicks on 'Add' button'.

Case B
User should not be allowed to enter any special character except (-) or 0 inside the Zip code field.

Case C
Manual inputs provided to both the fields are not getting saved.

Case D
Generate button can be changed to re-generate once the latitude/longitude are saved.

Case E
Regenerate option can be removed from the popover options and remove option can be given directly on the card itself.

R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue May 3, 2024
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform May 3, 2024
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to 📅 Planned in Digital Experience Platform Nov 20, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Dec 5, 2024
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📅 Planned
Development

No branches or pull requests

2 participants