Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Html tags with missing closing Quotes - How to avoid indesirable effects? #205

Open
pierzen opened this issue Mar 21, 2014 · 6 comments

Comments

@pierzen
Copy link

pierzen commented Mar 21, 2014

Using Html Tags, if you do not close a quote, for a style for example, the unbalanced HTML code causes the right panel information to move at the bottom of the left Panel.

Editors could surely correct the code. But we dont always realize when rushing to create new tasks in emergency. This as for effect that the instructions are obscured with some parts going at the botttom.

It should also be evaluated if this could cause problems on the server side.

See the example realized on the dev server.
http://tasks.dev.hotosm.org/job/450

In the Description section, you will se this instruction where the close quote is removed.

@wonderchook
Copy link

@dodobas do you think it would be better to use markdown to avoid these things? I guess some care in the filtering of formatting would still need to happen.

@pierzen
Copy link
Author

pierzen commented Mar 27, 2014

We have been able using HTML to style better, add colored box, etc to higlight infos, make better presentations. Markdown is quite restrictive.

The best would be simply to encapsulate info in one box (ie. short desc, desc) so that it has no effect on the content of an other box.

@dodobas
Copy link
Collaborator

dodobas commented Mar 27, 2014

well, you can either give users total control, which means that they need to know how to write HTML and how to fix problems which are caused by errors in RAW html ... or ... you could give them limited options like markdown/creole syntax and let some software worry about creating HTML

The third option would be to predefine a 'highlighted' CSS class and then use that, but you still need to careful when using quotes in the input boxes.

Fourth option would be to add 'highlighted_description' field on the model and preset the design...

@pierzen
Copy link
Author

pierzen commented Mar 27, 2014

I prefer to keep the flexibility of writing HTML.

I will try to think of an option to avoid open parenthesis to impact on other div panels.

@pgiraud
Copy link
Contributor

pgiraud commented Mar 27, 2014

We could also think about splitting instructions into several blocks.

On Thu, Mar 27, 2014 at 4:26 PM, Pierre Beland [email protected]:

I prefer to keep the flexibility of writing HTML.

I will try to think of an option to avoid open parenthesis to impact on
other div panels.

Reply to this email directly or view it on GitHubhttps://github.com//issues/205#issuecomment-38818032
.


| Pierre GIRAUD

@MarkCupitt
Copy link

The Preview shows you as you do it if any problems should be able to see them.

TO help with standardization, and non HTML savvy folks, it might be worth considering buttons for the few divs needed that insert the correct html with a ** Change This Text Here ** where the text should go.

It might pay to have an Urgent Div, Informational Div, Job Closed Div, and so on, at least they would all look the same over all the tasks ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants