Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial API call over 10mb #253

Open
smit1678 opened this issue Oct 8, 2017 · 3 comments
Open

Initial API call over 10mb #253

smit1678 opened this issue Oct 8, 2017 · 3 comments
Labels
v1 wontfix v1 bugs that will not be prioritized for fix, in favor of v2

Comments

@smit1678
Copy link
Collaborator

smit1678 commented Oct 8, 2017

Our initial API call for loading the browser is over 10mb. This is quite slow in a low bandwidth environment. But also you see the difference between the Latest imagery loading in the sidebar (smaller call, 22kb) and the main call for the map.

Idea for improving this: move to a filtered API call on load. Load with the filter in place for High resolution and within the Last month.

@smit1678
Copy link
Collaborator Author

I looked into this and attempted to play around with some solutions. One being, adjusting our main API query: https://github.com/hotosm/oam-browser/blob/oauth-login/src/stores/map_store.js#L61. Adjusting this to a limit that is lower reduces the size.

But it seems that all resulting views of the map are based on the initial API query. So when we limit this, then some data is never exposed through the grid.

@mojodna
Copy link
Collaborator

mojodna commented Oct 12, 2017

Because that call is used to initialize the state, I don't think there's a quick way to address this. We should probably be making tiled requests for imagery metadata (returning JSON with a max zoom). To avoid the initial load still being 10MB (split across multiple requests), only imagery sources that are large enough to be visible at a given zoom level based on their footprint could appear in a given tile response.

The app's state would be continuously updated as users pan around, loading additional metadata for imagery that becomes visible.

@smit1678 smit1678 added the ready label Oct 16, 2017
@smit1678
Copy link
Collaborator Author

The app's state would be continuously updated as users pan around, loading additional metadata for imagery that becomes visible.

Yeah. Also related to the issues hotosm/OpenAerialMap#95 and https://github.com/hotosm/OpenAerialMap/issues/100

@sharkinsspatial Thoughts on how we could approach this? Also related to our discussion around making the codebase more maintenance friendly.

@cgiovando cgiovando added the v1 wontfix v1 bugs that will not be prioritized for fix, in favor of v2 label Apr 13, 2021
@cgiovando cgiovando removed the ready label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 wontfix v1 bugs that will not be prioritized for fix, in favor of v2
Projects
None yet
Development

No branches or pull requests

3 participants