Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test and enable github action #5

Open
gengjiawen opened this issue Mar 17, 2020 · 3 comments
Open

add test and enable github action #5

gengjiawen opened this issue Mar 17, 2020 · 3 comments

Comments

@gengjiawen
Copy link

Seems no test configured in package.json

"test": "echo \"Error: no test specified\" && exit 1"

How about add tests and run it in CI ?

@hoperyy
Copy link
Owner

hoperyy commented Mar 17, 2020

@gengjiawen
Copy link
Author

test added /package.json@master#L7 @gengjiawen

The code is just a method call without any test case. It would be much better we add jest or ava to really test code.

@hoperyy
Copy link
Owner

hoperyy commented Mar 20, 2020

It's better! I'll add full tests when they're needed in newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants