Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UList #46

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

UList #46

wants to merge 22 commits into from

Conversation

mbutsk
Copy link
Member

@mbutsk mbutsk commented Jul 11, 2024 •
edited by bleudev
Loading

Add UList

closes #6

Summary by Sourcery

This pull request introduces the UList class for enhanced list manipulation and adds comprehensive docstrings to the UDict class methods for better documentation.

  • New Features:
    • Introduced UList class to simplify working with lists in Python, including methods for negation, item access, counting, insertion, replacement, copying, and arithmetic operations.
  • Enhancements:
    • Added docstrings to UDict class methods to improve code documentation and clarity.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 11, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new UList class for enhanced list operations and adds comprehensive docstrings to the UDict class for better documentation. The __init__.py file is updated to include the new ulist module.

File-Level Changes

Files Changes
ufpy/udict.py Added comprehensive docstrings to all methods and properties in the UDict class for better documentation and readability.
ufpy/__init__.py
ufpy/ulist.py		 Introduced a new UList class in ulist.py for enhanced list operations and updated __init__.py to include the new module.
Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbutsk - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Missing argument in count method. (link)
  • Incorrect iteration in call method. (link)
Here's what I looked at during the review
  • 🔴 General issues: 2 blocking issues, 4 other issues
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

ufpy/ulist.py Outdated Show resolved Hide resolved
ufpy/ulist.py Outdated Show resolved Hide resolved
ufpy/ulist.py Outdated Show resolved Hide resolved
ufpy/ulist.py Outdated Show resolved Hide resolved
ufpy/ulist.py Outdated Show resolved Hide resolved
ufpy/ulist.py Outdated Show resolved Hide resolved
ufpy/udict.py Show resolved Hide resolved
ufpy/ulist.py Outdated Show resolved Hide resolved
@bleudev bleudev marked this pull request as draft July 24, 2024 23:00
@bleudev bleudev added new feature New feature new class New class labels Jul 24, 2024
@bleudev bleudev added this to the 0.3 milestone Jul 24, 2024
@bleudev bleudev linked an issue Jul 24, 2024 that may be closed by this pull request
UList #6
Open
@bleudev bleudev changed the title ULst UList Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mbutsk mbutsk

@bleudev bleudev

Labels
new class New class new feature New feature
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

UList
2 participants
@mbutsk @bleudev