-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Get user preferences regarfin theme color and fix bug navigating to past and upcoming
Deploy preview for homeferences ready! Built with commit 17cc775 |
.gitignore
Outdated
@@ -1,4 +1,252 @@ | |||
|
|||
public/ | |||
# Created by https://www.toptal.com/developers/gitignore/api/macos,jetbrains+all,code,node,react |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't put your personal choice of editor files in here.
See coderbyheart/first-principles#30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I understand what you mean and I will revert it and handle it on my side, np 😄
However, just as a healthy discussion, I don't completely agree because specially in open-source it's utopic to believe that everyone will have a global git ignore file
that fits every use case and it's kind of an accident waiting to happen.
I wouldn't call it my personal preferences 😊 , It was generated using gitignore.io and I have been using it for so long that for me it feels kind of "standards", opinionated ones sure!
Thanks for the feedback will change it asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 17cc775
(feat) Get color theme from user preferences
(fix) Anchor links Past and Upcoming working again
(chore) Update .gitignore and core-js dependency explicit
PS - I tested it while it was live and everything seemed to be working fine ;)
Cheers