Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Get color theme from user preferences #51

Merged
merged 7 commits into from
Sep 19, 2020

Conversation

luisFilipePT
Copy link
Member

@luisFilipePT luisFilipePT commented Sep 19, 2020

(feat) Get color theme from user preferences
(fix) Anchor links Past and Upcoming working again
(chore) Update .gitignore and core-js dependency explicit

PS - I tested it while it was live and everything seemed to be working fine ;)

Cheers

@netlify
Copy link

netlify bot commented Sep 19, 2020

Deploy preview for homeferences ready!

Built with commit 17cc775

https://deploy-preview-51--homeferences.netlify.app

.gitignore Outdated
@@ -1,4 +1,252 @@

public/
# Created by https://www.toptal.com/developers/gitignore/api/macos,jetbrains+all,code,node,react
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put your personal choice of editor files in here.
See coderbyheart/first-principles#30

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I understand what you mean and I will revert it and handle it on my side, np 😄

However, just as a healthy discussion, I don't completely agree because specially in open-source it's utopic to believe that everyone will have a global git ignore file that fits every use case and it's kind of an accident waiting to happen.

I wouldn't call it my personal preferences 😊 , It was generated using gitignore.io and I have been using it for so long that for me it feels kind of "standards", opinionated ones sure!

Thanks for the feedback will change it asap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 17cc775

@coderbyheart coderbyheart merged commit d33fd8b into main Sep 19, 2020
@coderbyheart coderbyheart deleted the get-color-theme-from-user-preferences branch September 19, 2020 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants