You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is awesome! This gives us a lot of versatility and styling power. And the best part is that we are getting the icons directly from the design system.
The downside of using the component HdIcon on this case is that we lose the accessibility on the image. I believe that we should make a11y a first-class citizen on Homeday Blocks.
I suggest we implement accessibility on HdIcon adding the props:
title: string, optional, if not provided could work as an empty alt attribute.
id: string, optional, if not provided could be autogenerated
description: string, optional
I add a couple of screenshots from this accessible svgs post describing how could accessibility be implemented 😁.
Without
HdIcon
we could use ansvg
asset like this:With
HdIcon
we can make it inline thesvg
with the following code:This is awesome! This gives us a lot of versatility and styling power. And the best part is that we are getting the icons directly from the design system.
The downside of using the component
HdIcon
on this case is that we lose the accessibility on the image. I believe that we should make a11y a first-class citizen on Homeday Blocks.I suggest we implement accessibility on
HdIcon
adding the props:title
: string, optional, if not provided could work as an emptyalt
attribute.id
: string, optional, if not provided could be autogenerateddescription
: string, optionalI add a couple of screenshots from this accessible svgs post describing how could accessibility be implemented 😁.
Reference:
The text was updated successfully, but these errors were encountered: