Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider is show for older json.cgi versions #6

Closed
mattjoyce opened this issue Nov 2, 2015 · 2 comments
Closed

Slider is show for older json.cgi versions #6

mattjoyce opened this issue Nov 2, 2015 · 2 comments

Comments

@mattjoyce
Copy link
Contributor

I noticed that on one of my switches, that uses an older json.cgi, the slider is show, but is meaningless.
I'm not sure this is really a big problem, but a simple fix would be to test the version of json (info.version).

@Japh
Copy link
Contributor

Japh commented Nov 4, 2015

Ah, nice one! Yeah, that would be ideal. I guess at the moment, the assumption is that if you have the latest switcher.html on there, you'd also have the latest json.cgi.

I assume you're running the html from a separate device from this switch, which is just configured in switches.json?

Should be simple enough to check, but will get annoying as we develop more features and need to constantly check for supported features... something for #10.

@mattjoyce
Copy link
Contributor Author

yup, it will be annoying to have If Versions... everywhere. Increasingly so. I'm much more of a mind to add a manifest to the switch to describe what it can do, and have the controller respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants