Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small change #1675

Merged
merged 1 commit into from
Nov 9, 2023
Merged

small change #1675

merged 1 commit into from
Nov 9, 2023

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 9, 2023

small change

@donavanbecker
Copy link
Contributor

@mkz212 Thank you for all of your work on make the UI look awesome!

Going forward we would like to get one PR per release to merge into beta for testing. All of these small little changes are causing GitHub Actions to slow down which then causes builds to fail.

We will hold this PR until next release. Our recommendation would be to run homebridge-config-ui-x local with Visual Studio Code. nodemon is your best friend with running it local. If you need help with getting it setup and running correctly please join the Homebridge discord server.

Once again thanks!

@donavanbecker donavanbecker marked this pull request as draft November 9, 2023 16:04
@mkz212
Copy link
Contributor Author

mkz212 commented Nov 9, 2023

I think that this PR is only left. So far I have run out of ideas ;)

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 9, 2023

Also thank You @donavanbecker and @bwp91 for including all and for amazing job!

@donavanbecker
Copy link
Contributor

@mkz212 sounds good. We can include it in this PR, but will not be pushing any betas until we have somethings on outside figured out first. We can then include this and release after much beta testing from Users :)

@donavanbecker
Copy link
Contributor

@mkz212 feel free to reach out to us on discord.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 9, 2023

I don't insist, but it's just a small change, and it's actually been tested and it looked good. This is what we took to test if it causes the problem. In the sense it was already added and checked and it was ok. Then we removed it to see if it would help with this plug-in search and it didn't help, so that's not what caused the problem.

@donavanbecker
Copy link
Contributor

Okay, I will merge. Any PRs after this though I will wait for next release. Okay?

@donavanbecker donavanbecker marked this pull request as ready for review November 9, 2023 16:51
@donavanbecker donavanbecker merged commit 3ea959e into homebridge:beta-4.52.2 Nov 9, 2023
22 checks passed
@mkz212
Copy link
Contributor Author

mkz212 commented Nov 9, 2023

Everything looks ok in beta 69! I think it's ready!

@donavanbecker
Copy link
Contributor

Thanks @mkz212. We need to finish a few things on our side first and then will have a beta period. So be on the look out. Thanks!

@bwp91
Copy link
Contributor

bwp91 commented Nov 9, 2023

One more thing is bugging me

The tooltip does not disappear when opening modals

IMG_6664

is it possible to change this behaviour? @mkz212 i don’t think this has been caused by anything you have done, but if you are looking for stuff to do 😉

@mkz212 mkz212 deleted the patch-8 branch November 10, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants