Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libspeex and ffmpeg version update #80

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

n0rt0nthec4t
Copy link
Contributor

Current version of ffmpeg-for-homebridge dropped support from the v1 branch removing libspeex. libspeex is used by some cameras for talking audio

This amends the build process to include libspeex and also bumps the ffmpeg version from 6.0 to 6.1.2, the latest in the 6.x branch

if build "speex" "1.2.1"; then

  download "https://ftp.osuosl.org/pub/xiph/releases/speex/speex-1.2.1.tar.gz"

  execute ./configure --prefix="${WORKSPACE}" --disable-shared --enable-static
  execute make -j ${MJOBS}
  execute make install

  build_done "speex" "1.2.1"
fi

CONFIGURE_OPTIONS+=("--enable-libspeex")

@hjdhjd
Copy link
Collaborator

hjdhjd commented Oct 1, 2024

Thanks - will review. Do you have a working version of the build and a GH action build log I can review? Didn’t see one in your branch.

@n0rt0nthec4t
Copy link
Contributor Author

I'll submit a build log from my docker container that used to test an amd64 build if thats sufficient?

@hjdhjd
Copy link
Collaborator

hjdhjd commented Oct 1, 2024

I'll submit a build log from my docker container that used to test an amd64 build if thats sufficient?

A GH action please. It must build across all supported platforms. The GH action that I’ve built for ffmpeg-for-homebridge builds across all the supported OSs and created binaries for them. That’s why the validation is necessary.

Won’t accept a PR that is only validated across a subset of builds.

@n0rt0nthec4t
Copy link
Contributor Author

No worries.. just kicked off workflow action in the forked repo.

@hjdhjd
Copy link
Collaborator

hjdhjd commented Oct 1, 2024

No worries.. just kicked off workflow action in the forked repo.

Appreciated and appreciate you taking the time for it.

@n0rt0nthec4t
Copy link
Contributor Author

Ok. some error when cross platform. Looking into it.

@hjdhjd hjdhjd self-assigned this Oct 1, 2024
@hjdhjd
Copy link
Collaborator

hjdhjd commented Oct 1, 2024

Ok. some error when cross platform. Looking into it.

Looking good so far from what I could see…will review it’s status tomorrow, and will look to incorporate into an upcoming release (likely later in the week/weekend), assuming all is well.

@n0rt0nthec4t
Copy link
Contributor Author

No worries.. Looking better now on my side.. Had to change the download URL for ffmpeg. There are other updated libs, ut that might be for another day
Screenshot 2024-10-01 at 2 43 25 pm

@hjdhjd hjdhjd merged commit 04cee63 into homebridge:latest Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants