-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a network storage with a "umlaut" (Ä, Ö, Ü) causes supervisor to stop working #4483
Comments
Ah yes those characters cannot be used in a mount name since the mount name becomes the file name on disk. I didn't realize |
That's really the problem? Because actually you can use them in file names, both, in Windows and Linux. |
After looking at the changes you've made I think you misunderstood which field is causing the error. Sorry that I haven't clearly said that. It's the "Remote-Freigabe", not the "Name" (first field). There the check was successful. It didn't allowed me to use umlauts. That's why I replaced the json={
"name": "Uberwachungskameras",
"type": "cifs",
"usage": "share",
"server": "nas.local",
"share": "Überwachungskameras", # <-- This is what's failing
"version": "2.0",
}, |
It seems that this causes the D-Bus broker to disconnect the Supervisor 😰
To reproduce this there is no SMB server with a share with umlaut needed. It seems that the message we pass to systemd gets declined, before any connection attempt is being made. This is after clicking connect |
As @mdegat01 found, the underlying issue is actually in the D-Bus library. It is fixed by Bluetooth-Devices/dbus-fast#261. A bump in Supervisor will follow soon. |
This is resolved by #4603. |
Describe the issue you are experiencing
I had lots of trouble while trying to connect my network storage.
Let me tell what I did:
So I tried adding my network storage "Überwachungskameras" to the HA storage. After clicking connect, it would fail:
I really cannot find anything related to this in the logs or it's completely useless. It tells you like "The error is:" with nothing coming after it.
When clicking connect again nothing will happen. But this time the connect button is greyed out and the error message will disappear. Even after long waiting nothing happens.
And after that the problems began. So first I tried rebooting the host with the UI. It would not came back up and only show "connetion refused" (luckily it came back after cutting the power). Now, the next day, I tried again after updating core to the latest version. Same issue. Then a supervisor update appeared (from 2023.7.1 to 2023.8.1) on which I clicked install. First trough the UI (where it would be stuck for ~2 hours) and later with the command "ha supervisor update" where it told me finally something useful after around one hour of waiting:
Post “[http://supervisor/supervisor/update 10](http://supervisor/supervisor/update)”: context deadline exceeded (Client.Timeout exceeded while awaiting headers)
So after a lot of googling I found this thread. I executed the manual update script and finally the update was finished.. and I was able again to add other network storages. After trying it again with the "Überachungskameras" it failed again and the supervisor kind of crashed like before.
After some testing it clearly is the Umlaut (Ä, Ö, Ü) which is causing the issue.
In the name it is actually checking them. But not in the share name.
I know that the problem also is that the frontend is allowing these characters and thus "cause" the issue but I reported it here because I think it still is more supervisor related because a wrong character in my opinion should not crash the whole supervisor service. There needs to be better error handeling or timeouts. Or at best we get it to work with german umlauts. For me HA so far is the only thing which is causing problems with them.
Let me know if this is the wrong place and I should report the issue somewhere else.
What type of installation are you running?
Home Assistant OS
Which operating system are you running on?
Home Assistant Operating System
Steps to reproduce the issue
Anything in the Supervisor logs that might be useful for us?
System Health information
Nothing available
Supervisor diagnostics
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: