Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation of "entity" in Time condition summary #22984

Open
2 of 4 tasks
NoRi2909 opened this issue Nov 24, 2024 · 0 comments
Open
2 of 4 tasks

Missing translation of "entity" in Time condition summary #22984

NoRi2909 opened this issue Nov 24, 2024 · 0 comments

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Nov 24, 2024

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.
  • I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

If you select an entity instead of a fixed time for the Time condition of an automation the word "entity" is hard-coded into the summary string:

Screenshot 2024-11-24 20 24 14

This then also shows up still in English in translated context :

Screenshot 2024-11-24 20 23 32

Describe the behavior you expected

I would opt for simply dropping the word "entity" here as it's pretty clear how this is meant.

We do have the exact same bug with the time trigger, but given that the time trigger has three different ways of firing (according to the documentation):

  • at specified date & time
  • at midnight on specified date
  • once a day at specified time

there is further clarification needed. Depending on the kind of input the summary should spell this out in a proper sentence.

I will think about an ICU string for that and update this bug with a suggestion.

Steps to reproduce the issue

  1. Create a new automation.
  2. Add the Time condition.
  3. Select some entity instead of a fixed time.

What version of Home Assistant Core has the issue?

core-2024.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant