-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DHCP configuration update in HomeWizard #131547
Add DHCP configuration update in HomeWizard #131547
Conversation
…ard-dhcp-discovery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small comment to think about...
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @DCSBL 👍
../Frenck
Proposed change
Add
discovery-update-info
over DHCP for HomeWizard.As we store the unique_id as a
<product_typ>_<mac>
combo, we can't update the IP based on only the MAC. The current implementation feels as a workaround.We maybe want to convert the unique_id to just the MAC, as it is a unique value for HomeWizard.
Needs #131310
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: