Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DHCP configuration update in HomeWizard #131547

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Nov 25, 2024

Proposed change

Add discovery-update-info over DHCP for HomeWizard.

As we store the unique_id as a <product_typ>_<mac> combo, we can't update the IP based on only the MAC. The current implementation feels as a workaround.

We maybe want to convert the unique_id to just the MAC, as it is a unique value for HomeWizard.

Needs #131310

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@DCSBL DCSBL changed the title Add homewizard dhcp discovery Add DHCP configuration update in HomeWizard Nov 25, 2024
@DCSBL DCSBL marked this pull request as ready for review November 26, 2024 16:14
@DCSBL DCSBL marked this pull request as draft November 26, 2024 16:15
@DCSBL DCSBL marked this pull request as ready for review November 26, 2024 16:18
@DCSBL DCSBL marked this pull request as draft November 26, 2024 16:19
@DCSBL DCSBL marked this pull request as ready for review November 26, 2024 16:24
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small comment to think about...

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 26, 2024 18:11
@frenck frenck marked this pull request as ready for review November 26, 2024 18:16
@home-assistant home-assistant bot requested a review from frenck November 26, 2024 18:16
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @DCSBL 👍

../Frenck

@frenck frenck merged commit a9cab28 into home-assistant:dev Nov 26, 2024
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants