From 169079a9662f1e13bd7e17aa295fca1944ac748c Mon Sep 17 00:00:00 2001
From: Kamal Saleh <ksaleh87@yahoo.com>
Date: Mon, 6 Sep 2021 17:16:26 +0200
Subject: [PATCH] Add BasisOfExternalHom &
 CoefficientsOfMorphismWithGivenBasisOfExternalHom

as primitive methods in additive closure category.
---
 FreydCategoriesForCAP/gap/AdditiveClosure.gi | 84 ++++++++++++++++++++
 1 file changed, 84 insertions(+)

diff --git a/FreydCategoriesForCAP/gap/AdditiveClosure.gi b/FreydCategoriesForCAP/gap/AdditiveClosure.gi
index 7c25bb236c..71ca921a00 100644
--- a/FreydCategoriesForCAP/gap/AdditiveClosure.gi
+++ b/FreydCategoriesForCAP/gap/AdditiveClosure.gi
@@ -1127,6 +1127,90 @@ InstallGlobalFunction( INSTALL_FUNCTIONS_FOR_ADDITIVE_CLOSURE,
         
     fi;
     
+    if ForAll( [ "BasisOfExternalHom",
+                 "CoefficientsOfMorphismWithGivenBasisOfExternalHom",
+                 "ZeroMorphism" ], op -> CanCompute( underlying_category, op ) ) then
+      
+      ##
+      AddBasisOfExternalHom( category,
+        function( cat, object_1, object_2 )
+          local size_i, size_j, listlist, L;
+          
+          size_i := Size( ObjectList( object_1 ) );
+          size_j := Size( ObjectList( object_2 ) );
+          
+          listlist := List( [ 1 .. size_i ], i ->
+                        List( [ 1 .. size_j ], j ->
+                          ZeroMorphism( object_1[i], object_2[j] )
+                        )
+                      );
+          
+          return
+              Concatenation(
+                List( [ 1 .. size_i ], i ->
+                  Concatenation(
+                    List( [ 1 .. size_j ],
+                      function( j )
+                        local current_basis;
+                        
+                        current_basis := BasisOfExternalHom( object_1[ i ], object_2[ j ] );
+                        
+                        return List( current_basis,
+                                function( m )
+                                  local z;
+                                  z := listlist[ i, j ];
+                                  listlist[ i, j ] := m;
+                                  m := AdditiveClosureMorphismListList( object_1, listlist, object_2 );
+                                  listlist[ i, j ] := z;
+                                  return m;
+                                end
+                              );
+                      
+                      end
+                    )
+                  )
+                )
+              );
+      end );
+      
+      ##
+      InstallMethod( CoefficientsOfMorphism,
+                [ IsAdditiveClosureMorphism and MorphismFilter( category ) ],
+        
+        function( morphism )
+          local object_1, object_2, nr_rows, nr_cols;
+          
+          object_1 := Source( morphism );
+          
+          object_2 := Range( morphism );
+          
+          nr_rows := NumberRows( morphism );
+          
+          nr_cols := NumberColumns( morphism );
+          
+          return
+            Concatenation(
+              List( [ 1 .. nr_rows ],
+                  i -> Concatenation(
+                        List( [ 1 .. nr_cols ],
+                          j -> CoefficientsOfMorphismWithGivenBasisOfExternalHom(
+                                  morphism[ i, j ],
+                                  BasisOfExternalHom( object_1[ i ], object_2[ j ] )
+                              )
+                            )
+                          )
+                        )
+                      );
+      
+      end );
+      
+      ##
+      AddCoefficientsOfMorphismWithGivenBasisOfExternalHom( category,
+        {cat, morphism, B} -> CoefficientsOfMorphism( morphism )
+      );
+    
+    fi;
+    
 end );
 
 ####################################