Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move operations to compile in ModulePresentationsForCAP #1261

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

TKuh
Copy link
Collaborator

@TKuh TKuh commented Feb 27, 2023

and compile IsEqualForObjects and PreCompose.

See #932 (comment)

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 78.79% // Head: 78.77% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (56b0ee4) compared to base (9283a17).
Patch coverage: 62.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
- Coverage   78.79%   78.77%   -0.03%     
==========================================
  Files         496      496              
  Lines       60861    60929      +68     
==========================================
+ Hits        47957    47996      +39     
- Misses      12904    12933      +29     
Flag Coverage Δ
ActionsForCAP 65.09% <ø> (ø)
AttributeCategoryForCAP 88.45% <ø> (ø)
CAP 82.44% <ø> (ø)
CartesianCategories 92.37% <ø> (ø)
CompilerForCAP 94.94% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.68% <ø> (ø)
DeductiveSystemForCAP 25.42% <ø> (ø)
FreydCategoriesForCAP 80.73% <ø> (ø)
GeneralizedMorphismsForCAP 62.52% <ø> (ø)
GradedModulePresentationsForCAP 44.57% <ø> (ø)
GroupRepresentationsForCAP 72.09% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.08% <ø> (ø)
LinearAlgebraForCAP 65.42% <ø> (ø)
ModulePresentationsForCAP 68.82% <62.82%> (-0.37%) ⬇️
ModulesOverLocalRingsForCAP 90.02% <ø> (ø)
MonoidalCategories 87.28% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...esentationsForCAP/gap/ModulePresentationsForCAP.gi 69.88% <ø> (-0.43%) ⬇️
...egoryOfCategoryOfRowsOfArbitraryRingPrecompiled.gi 57.89% <46.15%> (-1.52%) ⬇️
...ryOfCategoryOfColumnsOfArbitraryRingPrecompiled.gi 57.89% <46.15%> (-1.52%) ⬇️
...ydCategoryOfCategoryOfColumnsOfFieldPrecompiled.gi 58.47% <46.15%> (-1.53%) ⬇️
...FreydCategoryOfCategoryOfRowsOfFieldPrecompiled.gi 66.10% <53.84%> (-1.52%) ⬇️
...oryOfCategoryOfRowsOfCommutativeRingPrecompiled.gi 90.67% <92.30%> (+0.20%) ⬆️
...OfCategoryOfColumnsOfCommutativeRingPrecompiled.gi 75.42% <92.30%> (+2.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@zickgraf zickgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

and compile IsEqualForObjects and PreCompose
@zickgraf zickgraf merged commit 7ed58e2 into homalg-project:master Feb 27, 2023
@TKuh TKuh deleted the compile_eq branch February 27, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants