Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new options for explicit conversion of data structures in WrapperCategory everywhere #980

Closed
zickgraf opened this issue Aug 15, 2022 · 2 comments · Fixed by #1259
Closed

Use new options for explicit conversion of data structures in WrapperCategory everywhere #980

zickgraf opened this issue Aug 15, 2022 · 2 comments · Fixed by #1259
Labels
help wanted tasks suited for external help

Comments

@zickgraf
Copy link
Member

#964 introduces new options for explicit conversion of data structures to WrapperCategory but does not use the new options at all places where WrapperCategory is currently used. These places are marked with TODO in the code. The old code is still valid, but using the new options would be nice for consistency.
@zickgraf zickgraf added the help wanted tasks suited for external help label Aug 15, 2022
@zickgraf
Copy link
Member Author

Only LeftPresentationsAsFreydCategoryOfCategoryOfRows and RightPresentationsAsFreydCategoryOfCategoryOfColumns are left. Those should be fixed as part of #937.

@zickgraf
Copy link
Member Author

@TKuh Could you tackle this as a preparation for #937/#932? This should affect the compiled code of IsEqualForObjects (and maybe other things), that's how I now come across this. Then we can first finish IsEqualForObjects and PreCompose which should be simple, and then finally the tensor structure.

TKuh pushed a commit to TKuh/CAP_project that referenced this issue Feb 21, 2023
Use modeling_* options in ModulePresentationsForCAP
cd63dbd 
Closes homalg-project#980
TKuh pushed a commit to TKuh/CAP_project that referenced this issue Feb 21, 2023
Use modeling_* options in ModulePresentationsForCAP
9033c59 
Closes homalg-project#980
TKuh pushed a commit to TKuh/CAP_project that referenced this issue Feb 21, 2023
Use modeling_* options in ModulePresentationsForCAP
1c7fa26 
Closes homalg-project#980
TKuh pushed a commit to TKuh/CAP_project that referenced this issue Feb 21, 2023
Use modeling_* options in ModulePresentationsForCAP
3f07664 
Closes homalg-project#980
@TKuh TKuh mentioned this issue Feb 21, 2023
Merged
TKuh pushed a commit to TKuh/CAP_project that referenced this issue Feb 22, 2023
Use modeling_* options in ModulePresentationsForCAP
24a6c68 
Closes homalg-project#980
TKuh pushed a commit to TKuh/CAP_project that referenced this issue Feb 27, 2023
Use modeling_* options in ModulePresentationsForCAP
dc6dac2 
Closes homalg-project#980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted tasks suited for external help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use modeling_* options in ModulePresentationsForCAP TKuh/CAP_project
1 participant
@zickgraf