Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #2139: Fix wrong translation for Spanish for 'worstOfSeason' #2142

Conversation

sgcr
Copy link
Collaborator

@sgcr sgcr commented Aug 26, 2024

  1. changes proposed in this pull request:
  1. src/main/resources/release_notes.md ...
  • has been updated
  1. [Optional] suggested person to review this PR @wsbrenk
    I've made the changes also in POEditor...

@sgcr sgcr changed the base branch from master to release/8 August 26, 2024 21:20
@sgcr sgcr mentioned this pull request Aug 27, 2024
1 task
@tychobrailleur
Copy link
Collaborator

If you've made the change to POEditor, would you mind reverting the change to the properties file in the code file (but keep the release note entry)? Just to avoid potential conflicts in the future. Thanks!

@tychobrailleur
Copy link
Collaborator

If you've made the change to POEditor, would you mind reverting the change to the properties file in the codebase (but keep the release note entry)? Just to avoid potential conflicts in the future. Thanks!

Copy link
Collaborator

@wsbrenk wsbrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poeditor integration is working again - so all translations should be done in poeditor now

New terms of the english properties file will be uploaded automatically to poeditor.

I would suggest to close this pr.

@sgcr sgcr force-pushed the bugfix/bug-2139-wrong-translation-for-spanish-for-worst-of-season branch from b546d68 to 8323e74 Compare September 7, 2024 13:27
@sgcr
Copy link
Collaborator Author

sgcr commented Sep 7, 2024

poeditor integration is working again - so all translations should be done in poeditor now

New terms of the english properties file will be uploaded automatically to poeditor.

I would suggest to close this pr.

Only release_notes.md is updated.
Can be merged.

@sgcr sgcr requested a review from wsbrenk September 7, 2024 13:29
@tychobrailleur tychobrailleur merged commit b0171ff into ho-dev:release/8 Sep 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants