Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Arena sizer: Add the general information about the current stadium #2140

Closed
sgcr opened this issue Aug 26, 2024 · 1 comment
Closed
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@sgcr
Copy link
Collaborator

sgcr commented Aug 26, 2024

Is your feature request related to a problem? Please describe.
As a new contributor for HO I was looking for a small side project.
I saw the "Arena sizer" within the "Tools" and was missing the general information about the current stadium.
When clicking the UI, I recognized that clicking on the name of my stadium shows the same content when clicking on "Arena".
So it might be a good idea to show in the tab with the stadium name the details about my stadium.

Describe the solution you'd like
Please look at the screenshot to have an impression for the proposal.
3 group boxes from left to right containing the current, expansion and future of your stadium.
Each group box contains 3 columns: place type, places and the rate (or change) in percent.
the number of terraces, basic seating, seats under roof, seats in VIP boxes and and the total seats.
In the last line there is space for group box specific information.

The left group box "Current" shall show the normal information and of the stadium and in the last line is shown when the stadium was last improved or if there is a construction in progress.

The middle group box "Expansion" shall show the expansion of seats if there is any.
The number in the "Places" column should be with positive or negative sign in the specific color for that.
The percentage in third column "Change in %" shall show change in percent of each category (compared to the current places). The number in percent shall be shown with positive or negative sign in the specific color for that.
The last line shows when the current expansion is completed and an additional label with the remaining duration that is updated each second.

The last group box "Future" shall show the future of the stadium if there is an expansion in progress.
The future is the sum of current and expansion places for each type. The rate in percent shows how the rate of your stadium looks like after the expansion.
The last line shows the day when the future is reality (the next after completion).

Proposal
Proposal_AreaInfoPanel

sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Aug 26, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Aug 26, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Aug 26, 2024
@tychobrailleur
Copy link
Collaborator

Nice! And welcome! I like the proposal, and great contribution (in particular the tests!!). I have added some comments to the review.

@wsbrenk wsbrenk added this to the 9.0 milestone Aug 31, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 3, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 3, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 3, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 4, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 7, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 10, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 23, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 23, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 24, 2024
sgcr added a commit to sgcr/HattrickOrganizer that referenced this issue Sep 29, 2024
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Oct 12, 2024
@wsbrenk wsbrenk closed this as completed Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

3 participants