[BUG] Building stable release of HO 8.1 failed

[wsbrenk]

Describe the bug
A clear and concise description of what the bug is.

Task :buildSrc:compileKotlin
w: file:///home/runner/work/HattrickOrganizer/HattrickOrganizer/buildSrc/src/main/kotlin/poeditor/PullRunnable.kt:59:50 Unnecessary non-null assertion (!!) on a non-null receiver of type File?
w: file:///home/runner/work/HattrickOrganizer/HattrickOrganizer/buildSrc/src/main/kotlin/poeditor/PullTask.kt:51:50 Type mismatch: inferred type is String? but Any was expected
w: file:///home/runner/work/HattrickOrganizer/HattrickOrganizer/buildSrc/src/main/kotlin/poeditor/PullTask.kt:52:40 Type mismatch: inferred type is List? but (Mutable)Iterable<String?> was expected

Task :buildSrc:compileJava NO-SOURCE
Task :buildSrc:compileGroovy NO-SOURCE
Task :buildSrc:classes UP-TO-DATE

Task :buildSrc:jar
🫙 No valid plugin descriptors were found in META-INF/gradle-plugins

FAILURE: Build failed with an exception.

• What went wrong:
  A problem occurred configuring root project 'HO'.

Could not resolve all files for configuration ':classpath'.
Could not find com.overzealous:remark:1.1.0.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
Searched in the following locations:
- https://plugins.gradle.org/m2/com/overzealous/remark/1.1.0/remark-1.1.0.pom
Required by:
project : > org.kordamp.gradle.markdown:org.kordamp.gradle.markdown.gradle.plugin:2.2.0 > org.kordamp.gradle:markdown-gradle-plugin:2.2.0

[wsbrenk]

@tychobrailleur Again a poeditor issue!? what do you think about bringing the language translation files back to the HO repo?

[wsbrenk]

kordamp/markdown-gradle-plugin#34 seems to be the reason of this failure

[wsbrenk]

@tychobrailleur it looks like kotlin supports md to html conversion. it might be the easiest solution to create again our own gradle plugin?

[tychobrailleur]

@tychobrailleur it looks like kotlin supports md to html conversion. it might be the easiest solution to create again our own gradle plugin?

Yeah, as a stop-gap measure, it sounds good. Let me look into this.

[tychobrailleur]

It seems @simonpoole already did the heavy lift for us; we just have to wait for the 0.2.5 release of the hard fork! ;-)

[simonpoole]

Just as a clarification: I hard forked the dependency causing the issue (remark-java) here https://github.com/simonpoole/remark-java, no heavy lifting required (I did update a couple of dependencies and moved the build to gradle). Both the docs and a couple of other things need clean up, but outside of that it works..

The other thing is that I use it in a version of the markdown gradle plugin that I forked a long time ago which has a couple of extra features but which is not synced with the original. Currently I would not recommend using my fork, as there are a number of security issues with the version of flexmark that I'm using (that are however not relevant for my use case) and likely it would probably be better to merge my changes back in to upstream now that it is showing life again.

tl;dr you should get the maintainer of the gradle plugin to use my fork of remark-java if you want quick resolution.

[tychobrailleur]

tl;dr you should get the maintainer of the gradle plugin to use my fork of remark-java if you want quick resolution.

Awesome, thanks for taking the time to clarify the state of your fork, really appreciate! Will see how to get this addressed upstream.

[tychobrailleur]

This job completed successfully. I'll cherry-pick the change on master.

[tychobrailleur]

This job completed successfully. I'll cherry-pick the change on master.

This is now done, and the job completed successfully.