Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error in download at Create staff stage #1913

Closed
Moshu opened this issue Sep 8, 2023 · 9 comments
Closed

[BUG] Error in download at Create staff stage #1913

Moshu opened this issue Sep 8, 2023 · 9 comments
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@Moshu
Copy link

Moshu commented Sep 8, 2023

While performing the download, the process is interrupted by a java.lang.StackOverflowError. The stage in the left bottom corner is "Create staff...". However, I think it occurs for a particular player, since after the error some of the players are missing from my team.

This happens for two of my three teams, Shopska s rakia (664030) and Elaiolado (904313). Each of them have a new player promoted from the youth team shortly before the download, maybe this is the cause, but it worked fine in the past in such conditions.

Screenshot 2023-09-08 102530

  • OS: Windows 11
  • Version 7.2

The complete log in the error window is:

java.lang.StackOverflowError
at java.base/java.io.InputStream.(InputStream.java:61)
at java.base/java.io.FilterInputStream.(FilterInputStream.java:60)
at java.base/sun.net.www.MeteredStream.(MeteredStream.java:50)
at java.base/sun.net.www.http.KeepAliveStream.(KeepAliveStream.java:60)
at java.base/sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:1014)
at java.base/sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:726)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1688)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:529)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:308)
at com.github.scribejava.core.httpclient.jdk.JDKHttpClient.doExecute(JDKHttpClient.java:139)
at com.github.scribejava.core.httpclient.jdk.JDKHttpClient.execute(JDKHttpClient.java:94)
at com.github.scribejava.core.oauth.OAuthService.execute(OAuthService.java:114)
at core.net.MyConnector.getCHPPWebFile(MyConnector.java:630)
at core.net.MyConnector.downloadPlayerDetails(MyConnector.java:432)
at core.net.OnlineWorker.downloadPlayerDetails(OnlineWorker.java:1193)
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:499)
at core.model.player.Player.getMotherclubId(Player.java:488)
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:501)
at core.model.player.Player.getMotherclubId(Player.java:488)
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:501)
...

@manguz
Copy link

manguz commented Sep 8, 2023

Yeah, can confirm.
I use 2 seperate instance of HO, one for main team and one for the Anniversary team.
The AT one downloads data correctly, while the main one fails and in the main one I have a new player promoted from youth some days ago.
this Player is already present in the roster in the dB as it was created some days ago when it worked downloading data.

errorLOG.txt

@tychobrailleur
Copy link
Collaborator

I have tried two players in the CHPP example page for playerdetails, one homegrown, one not, and neither come back with the MotherClub tag in version 2.9 (which I understand is the version where that tag has been added). Ironically the MotherClubBonus tag that used to be returned is also not returned in 2.9.

@wsbrenk is that a CHPP regression?

@wsbrenk
Copy link
Collaborator

wsbrenk commented Sep 8, 2023

Looks like a bug in the chpp playerdetails file. this was mentioned in the chpp forum. Should be fixed now.

@wsbrenk wsbrenk self-assigned this Sep 8, 2023
wsbrenk added a commit to wsbrenk/HO that referenced this issue Sep 8, 2023
@wsbrenk wsbrenk added this to the 7.3 milestone Sep 8, 2023
@wsbrenk
Copy link
Collaborator

wsbrenk commented Sep 8, 2023

chpp returns playerdetails Version 1.2 although Version 2.9 was requested - crazy!

wsbrenk added a commit to wsbrenk/HO that referenced this issue Sep 8, 2023
@orrinoAriel
Copy link

Hi there!
I'm experiencing the same mentioned issue...
This is the backtrace log error

java.lang.StackOverflowError
at java.base/com.sun.crypto.provider.GHASH.doFinal(GHASH.java:221)
at java.base/com.sun.crypto.provider.GHASH.doFinal(GHASH.java:343)
at java.base/com.sun.crypto.provider.GaloisCounterMode$GCMEngine.doLastBlock(GaloisCounterMode.java:797)
at java.base/com.sun.crypto.provider.GaloisCounterMode$GCMDecrypt.doFinal(GaloisCounterMode.java:1471)
at java.base/com.sun.crypto.provider.GaloisCounterMode.engineDoFinal(GaloisCounterMode.java:447)
at java.base/javax.crypto.Cipher.doFinal(Cipher.java:2500)
at java.base/sun.security.ssl.SSLCipher$T12GcmReadCipherGenerator$GcmReadCipher.decrypt(SSLCipher.java:1659)
at java.base/sun.security.ssl.SSLSocketInputRecord.decodeInputRecord(SSLSocketInputRecord.java:260)
at java.base/sun.security.ssl.SSLSocketInputRecord.decode(SSLSocketInputRecord.java:181)
at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:111)
at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1508)
at java.base/sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1479)
at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:1064)
at java.base/java.io.BufferedInputStream.fill(BufferedInputStream.java:244)
at java.base/java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
at java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:343)
at java.base/sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:791)
at java.base/sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:726)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1688)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:529)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:308)
at com.github.scribejava.core.httpclient.jdk.JDKHttpClient.doExecute(JDKHttpClient.java:139)
at com.github.scribejava.core.httpclient.jdk.JDKHttpClient.execute(JDKHttpClient.java:94)
at com.github.scribejava.core.oauth.OAuthService.execute(OAuthService.java:114)
at core.net.MyConnector.getCHPPWebFile(MyConnector.java:630)
at core.net.MyConnector.downloadPlayerDetails(MyConnector.java:432)
at core.net.OnlineWorker.downloadPlayerDetails(OnlineWorker.java:1193)
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:503)
at core.model.player.Player.getMotherclubId(Player.java:492)
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:505)
at core.model.player.Player.getMotherclubId(Player.java:492)
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:505)
at core.model.player.Player.getMotherclubId(Player.java:492)
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:505)
at core.model.player.Player.getMotherclubId(Player.java:492)
......

After that, these two lines are repeated a lot of times
at core.model.player.Player.downloadMotherclubInfoIfMissing(Player.java:505)
at core.model.player.Player.getMotherclubId(Player.java:492)

As other guys mentioned, I have a new player recently promoted to the main team.

I tried with the last stable version(7.2.X) and with the last dev version (8.0-r518)

wsbrenk added a commit to wsbrenk/HO that referenced this issue Sep 8, 2023
wsbrenk added a commit that referenced this issue Sep 8, 2023
* #1913 fix Player.getMotherclubId download recursion

* #1913 fix Player.getMotherclubId
@wsbrenk
Copy link
Collaborator

wsbrenk commented Sep 8, 2023

i just reproducede with my own team. the reason is an error in chpp - i hope with the fix, the next ho version will survive such errors.

@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Sep 8, 2023
@orrinoAriel
Copy link

@wsbrenk i can test it if you wish

@Moshu
Copy link
Author

Moshu commented Sep 9, 2023

I have just received this, maybe this was the cause.

_Newsletter from CHPP Admins
Conversation with CHPP-teles

Hello CHPP devs!

A quick info to announce the last changes on chpp data.
There are new version for some files, especially players and playerdetails
In those files the trainer is no more included if he is not a also player.
To be sure to get the trainer data, for a pure trainer, a player trainer or a hof trainer, you have to fetch the new version of stafflist, and staffavatars to get its avatar.

This change was done to reflect the last changes on trainers in the game.

Have a look at the documentation (/Community/CHPP/NewDocs/) and don't forget to update your code when you update the file version!_

@Moshu
Copy link
Author

Moshu commented Sep 9, 2023

I tested with the beta version, everything is back to normal. Thank you! :-)

@wsbrenk wsbrenk closed this as completed Sep 9, 2023
wsbrenk added a commit to wsbrenk/HO that referenced this issue Sep 9, 2023
wsbrenk added a commit that referenced this issue Oct 1, 2023
* team analyzer filter handles challenger cup as friendlies now

* logging RatingPredictionManager

* Speciality.java->specialty

* rating logging

* refactoring RatingPredictionManager

* #1782 start schum rating

* #1782 schum rating

* #1782 RatingPredictionManager teamspirit formula

* #1805 release_notes.md

* typo

* #1782 rating refactoring

* #1782 rating refactoring

* #1782 rating refactoring

* #1782 add experience calculations to strenght cache

* init ratingprediction.json

* json preciction definition

* ratingprediction.json

* start HO7.1

* start HO8.0

* continue

* Release/7 (#1859)

* start HO7.1

* #1856 fix currency of secondary teams

* #1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1857 fix playername getter in MatchHighlightsTable (#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1861 fix exception in GoalDiffCriteria (#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* #1858 (#1869)

* #1858 debug date time parsing

* #1858 debug currency parsing

* #1858 using Helper.formatCurrency

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 translate comments in Helper.java

* #1858 remove  unused imports in HODateTime.java (add some comments)

* #1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* #1858 fix PlayerConverter add comment explaining offsSpecialty

* #1858 fix PlayerConverter remove old commented methods

* #1858 fix PlayerConverter.parseLocalDateTime

* #1858 PlayerConverter scan wage

* #1858 PlayerConverter scan skill refactored

* #1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>

* refactor rating prediction

* #1873 (#1874)

* #1873 fix MatchAndLineupSelectionPanel.updateStyleOfPlayComboBox nt team selection

* #1873 release_notes.md

* ratingprediction formulas (wip)

* #1878 (#1879)

* fix OnlineWorker.downloadLastLineup

* MyConnector.downloadPlayerDetails include match info

* #1878 release_notes.md

* #1878 show last match date of nt team players

* RatingPredictionManager remove debug logs

* new class RatingPredictionModel

* new class RatingPredictionModel

* #1881 (#1882)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 debug worlflow (#1883)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 fix workflow

* RatingPredictionModel (wip)

* Release ho7.1 (#1887)

* release_notes.md update translaation statistics

* release_notes.md

* release HO 7.1

* release_notes.md

* RatingPredictionModel

* #1889 download new trainer info from player details (#1890)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* stable 7.2 (#1893)

* rating prediction (wip)

* rating prediction (wip)

* #1899 (#1900)

* #1899 training recalculation recovers deleted skill ups

* #1901 PlayerDetailsPanel reset homegrown icon (#1902)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* calcTeamSpirit

* fix RatingChartData

* fix RatingChartData

* fix RatingChartData

* #1849 (#1912)

* ModuleConfigTable.saveConfig

* Update install4j version. (#1906)

This is an attempt at fixing issue #1849 by updating install4j to the latest
version, as it is unclear at this point what is causing the install to hang on
some MacOS machines.

(cherry picked from commit d2a5b0b)

* release-dev INSTALL4J_HOME (#1907)

(cherry picked from commit 628d685)

* https://github.com/ho-dev/HattrickOrganizer (#1911)

(cherry picked from commit 823bfa0)

* #1849 release_notes.md

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>

* wip

* #1913 fix Player.getMotherclubId

* fit values of RatingPredictionModel.calcSector

* RatingPredictionModel.calcRatingSectorScale

* RatingPredictionModel.calcPlayerScale (wip)

* Player.getPositionRating

* copyrights

* getPlayerMatchAverageRating

* fix edit SubstitutionEditView hatstats update

* fix Substitution.pos

* fix Substitution.setRoleId

* fix RatingPredictionModel.calcStamina

* tune RatingPredictionModel.getRatingSectorScaleFactor

* fix enum coding style

* read.me

* adjust player rating to hatstats formula (factor 3 for midfield contribution)

* implement schum rank

* tychobrailleur's review

* release_notes.md

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Co-authored-by: Sébastien Le Callonnec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

5 participants