Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] player details shows wrong heart #1901

Closed
wsbrenk opened this issue Jul 29, 2023 · 0 comments
Closed

[BUG] player details shows wrong heart #1901

wsbrenk opened this issue Jul 29, 2023 · 0 comments
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented Jul 29, 2023

image

@wsbrenk wsbrenk self-assigned this Jul 29, 2023
@wsbrenk wsbrenk added this to the 7.3 milestone Jul 29, 2023
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jul 29, 2023
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Jul 29, 2023
@wsbrenk wsbrenk closed this as completed Aug 14, 2023
wsbrenk added a commit that referenced this issue Oct 1, 2023
* team analyzer filter handles challenger cup as friendlies now

* logging RatingPredictionManager

* Speciality.java->specialty

* rating logging

* refactoring RatingPredictionManager

* #1782 start schum rating

* #1782 schum rating

* #1782 RatingPredictionManager teamspirit formula

* #1805 release_notes.md

* typo

* #1782 rating refactoring

* #1782 rating refactoring

* #1782 rating refactoring

* #1782 add experience calculations to strenght cache

* init ratingprediction.json

* json preciction definition

* ratingprediction.json

* start HO7.1

* start HO8.0

* continue

* Release/7 (#1859)

* start HO7.1

* #1856 fix currency of secondary teams

* #1856 fix currency of secondary teams

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1857 fix playername getter in MatchHighlightsTable (#1860)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* #1861 fix exception in GoalDiffCriteria (#1864)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>

* Fix click on “Last Match” column when it has been moved. (#1863)

The “Last Match” column is clickable, and opens:
- The match in Hattrick when shift-clicking,
- The match in HO when double-clicking.

This commit also adds some comment to clarify the behaviour.

* Minor UI improvement in teamAnalyzer. (#1867)

This adds a bit of padding around the check boxes on the teamAnalyser panel,
and centers the automatic / manual radio buttons.

It also cleans up code a bit, in particular in lineup assistant.  Probably more
effort to come on that front.

* #1858 (#1869)

* #1858 debug date time parsing

* #1858 debug currency parsing

* #1858 using Helper.formatCurrency

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 Player.baseWage reset setter getter (not used for now, but senseful for the future)

* #1858 translate comments in Helper.java

* #1858 remove  unused imports in HODateTime.java (add some comments)

* #1858 fix Player.setExpiryDate, use localized DateTimeFormatter

* #1858 fix PlayerConverter add comment explaining offsSpecialty

* #1858 fix PlayerConverter remove old commented methods

* #1858 fix PlayerConverter.parseLocalDateTime

* #1858 PlayerConverter scan wage

* #1858 PlayerConverter scan skill refactored

* #1858 PlayerConverter scan wage
fix indexRowWarning

* Fixes deadline date parsing in Transfer Scout.

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>

* refactor rating prediction

* #1873 (#1874)

* #1873 fix MatchAndLineupSelectionPanel.updateStyleOfPlayComboBox nt team selection

* #1873 release_notes.md

* ratingprediction formulas (wip)

* #1878 (#1879)

* fix OnlineWorker.downloadLastLineup

* MyConnector.downloadPlayerDetails include match info

* #1878 release_notes.md

* #1878 show last match date of nt team players

* RatingPredictionManager remove debug logs

* new class RatingPredictionModel

* new class RatingPredictionModel

* #1881 (#1882)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 debug worlflow (#1883)

* some cleanup

* #1881 add undocumented goal difference criteria

* #1881 add undocumented goal difference criteria release_notes.md

* #1881 fix workflow

* RatingPredictionModel (wip)

* Release ho7.1 (#1887)

* release_notes.md update translaation statistics

* release_notes.md

* release HO 7.1

* release_notes.md

* RatingPredictionModel

* #1889 download new trainer info from player details (#1890)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* stable 7.2 (#1893)

* rating prediction (wip)

* rating prediction (wip)

* #1899 (#1900)

* #1899 training recalculation recovers deleted skill ups

* #1901 PlayerDetailsPanel reset homegrown icon (#1902)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* RatingPredictionModel (wip)

* calcTeamSpirit

* fix RatingChartData

* fix RatingChartData

* fix RatingChartData

* #1849 (#1912)

* ModuleConfigTable.saveConfig

* Update install4j version. (#1906)

This is an attempt at fixing issue #1849 by updating install4j to the latest
version, as it is unclear at this point what is causing the install to hang on
some MacOS machines.

(cherry picked from commit d2a5b0b)

* release-dev INSTALL4J_HOME (#1907)

(cherry picked from commit 628d685)

* https://github.com/ho-dev/HattrickOrganizer (#1911)

(cherry picked from commit 823bfa0)

* #1849 release_notes.md

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>

* wip

* #1913 fix Player.getMotherclubId

* fit values of RatingPredictionModel.calcSector

* RatingPredictionModel.calcRatingSectorScale

* RatingPredictionModel.calcPlayerScale (wip)

* Player.getPositionRating

* copyrights

* getPlayerMatchAverageRating

* fix edit SubstitutionEditView hatstats update

* fix Substitution.pos

* fix Substitution.setRoleId

* fix RatingPredictionModel.calcStamina

* tune RatingPredictionModel.getRatingSectorScaleFactor

* fix enum coding style

* read.me

* adjust player rating to hatstats formula (factor 3 for midfield contribution)

* implement schum rank

* tychobrailleur's review

* release_notes.md

---------

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Co-authored-by: Sébastien Le Callonnec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

1 participant