Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move repository to https://github.com/ho-dev #1736

Closed
12 tasks done
wsbrenk opened this issue Dec 7, 2022 · 41 comments
Closed
12 tasks done

[FEATURE] Move repository to https://github.com/ho-dev #1736

wsbrenk opened this issue Dec 7, 2022 · 41 comments
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented Dec 7, 2022

Todo:

what is missing?

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 7, 2022

@akasolace , @tychobrailleur i think i need some help to do this.

@tychobrailleur
Copy link
Collaborator

tychobrailleur commented Dec 7, 2022

There are other things like:

  • Do you want to migrate issues to new repo, or start with a blank slate
  • Add permissions to existing developers
  • Update links to new repo (a quick grep in the repo for https://github.com/akasolace/HO returns a few hits, in particular the links for the check for updates)
  • Update current repo to mark it as deprecated, and link to new one

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 7, 2022

Thanks @tychobrailleur : added your points to task list.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 10, 2022

@akasolace do you agree with first list item?

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 11, 2022

As an alternative to point 1, we could create a new GitHub organization (hattrick-organizer)

@akasolace
Copy link
Collaborator

Done

@wsbrenk wsbrenk added this to the 8.0 milestone Dec 17, 2022
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 18, 2023

On the new repo we should enhance the download feature: #1753. @tychobrailleur: What do you think

@tychobrailleur
Copy link
Collaborator

Just pushed the master branch there:
https://github.com/ho-dev/HO

Need to see how to get all other branches, and the issues from repo.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 18, 2023

great!

concerning branches - i think only the release branches are useful
issues are very useful
and the actions

@tychobrailleur
Copy link
Collaborator

tychobrailleur commented Mar 18, 2023 via email

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 19, 2023

I just remember: In the release notes and the change logs I have included links to the milestones (Detailed changelog). It would be great if we could set them up in the new repo as well.

@tychobrailleur
Copy link
Collaborator

great!

concerning branches - i think only the release branches are useful issues are very useful and the actions

For issues it looks like they can only be “transferred:” https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository

Not sure if we want to do this now, or wait a bit?

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 19, 2023

that sounds very tedious, so we should look for better solutions (or program them ourselves;-)

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 19, 2023

@tychobrailleur transferring a repository looks like the most easily way.

As far as i understand this, we have to create a copy of the repo at its origin place (akasolace) that will hold all the stuff that is needed to lead the users to the new place.

@tychobrailleur
Copy link
Collaborator

I have migrated the Wiki pages too:
https://github.com/ho-dev/HO/wiki

@akasolace
Copy link
Collaborator

@wsbrenk @tychobrailleur please let me know when the transfer is over I will then archive the HO repository on my account ....

@tychobrailleur
Copy link
Collaborator

tychobrailleur commented Mar 19, 2023 via email

@akasolace
Copy link
Collaborator

I did it once using pyGithub, I will try to find it ....

@akasolace
Copy link
Collaborator

akasolace commented Mar 19, 2023

Actually no what I had to do was to duplicates issues but simple transfer is supported directly by the API. Strange that you are running into issues ... here something that can help

https://jloh.co/posts/bulk-migrate-issues-github-cli/

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 19, 2023

please let me know when the transfer is over I will then archive the HO repository on my account ....

Hi @akasolace, we had planned to set up your page as a redirection to the new page for a while. at least until most users have moved to the new site via HO update.

@akasolace
Copy link
Collaborator

I guess it can still be archived and serve that purpose but you will let me know !

@tychobrailleur
Copy link
Collaborator

Actually no what I had to do was to duplicates issues but simple transfer is supported directly by the API. Strange that you are running into issues ... here something that can help

https://jloh.co/posts/bulk-migrate-issues-github-cli/

Troubleshooting the python I was using, this seems to be caused by throttling:

"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later."

I'll have to update the script to include the retry after the rest period.

@tychobrailleur
Copy link
Collaborator

@tychobrailleur transferring a repository looks like the most easily way.

Yeah, I think you're right. Copying issues is just not workable with rate limits, and the ownership of issues and comments would be all me, which is not ideal.

Maybe we should just bite the bullet and do it, and then deal with the resulting issues?

As far as i understand this, we have to create a copy of the repo at its origin place (akasolace) that will hold all the stuff that is needed to lead the users to the new place.

An empty repo with just a link in the README to the new repo, is that it?

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 21, 2023

@tychobrailleur i fear we'll need something more. At minimum all the tags (dev, beta, tag_stable) which are needed by the existing HOs in the world to download updates.

The newest HO version (HO7 or HO8) we should also place in origin repo, with links to the updates in the new repo.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 21, 2023

maybe this is possible by redirecting those tags (links). But i have no idea how that works.

@tychobrailleur
Copy link
Collaborator

  • All the tags are in place right now in the new repo. Any new release from ho-dev should point there. I am not sure what the next major version is (HO7?), but that one should be cut off the new repo, and updates will point to new repo. All good there.
  • Old releases will point to old repo, and hardcoded to point to old repo. Unless somehow we rewrite the URL (I don't know of such mechanism on github, but it looks like your github-foo exceeds mine by far, @wsbrenk), I am not sure how we can get around this. These are the update URLs:
	public VersionInfo getLatestStableVersion() {
		return getVersion("https://github.com/akasolace/HO/releases/download/tag_stable/version.properties");
	}

	public VersionInfo getLatestVersion() {
		return getVersion("https://github.com/akasolace/HO/releases/download/dev/version.properties");
	}

	public VersionInfo getLatestBetaVersion() {
		return getVersion("https://github.com/akasolace/HO/releases/download/beta/version.properties");
	}

One way we could approach this is:

  • First make a new release on akasolace repo with a code change where we update the “check the new version logic” to first look at ho-dev, and if nothing, look at akasolace.
  • Once that release has been pushed we should be good to migrate.
  • At that point we could archive akasolace repo. Presumably this should keep old releases around.

I am sick at the moment, so my brains are not working very well, so there may very well be gaps in that reasoning, but these are my thoughts right now.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 21, 2023

@tychobrailleur Get well soon!!!

  • the next major version is HO7. it is beta now and still some bug fixes concerning nt teams have to be fixed. when we change the update urls to the new repo, not only the tags have to be in place but also (pre) releases with all the required assets.
  • the final version on old repo should point to update urls on new repo. then update requests of older versions can update to exact that version. updating this version will update to newer versions on new repo.
  • alternativly we find a way that redirect update urls of the older HO versions to the tags of the new repo (but i don't have any idea, how to do that)
  • beautify: i don't know the reason, why the tags are named by different conventions. when we are changing, i would suggest to name them uniquely. either stable, beta, dev or tag_stable, tag_beta, tag_dev. i would prefer the first suggestion.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented May 9, 2023

@tychobrailleur how to go on further with this issue?

if there are no further bug reports, i would like to release stable 7.1 in about 2 weeks.
then we could move to the new place.

in this repository (akasolace) i would like to release a stable 7.2 with modified update links to the new place. what do you think about this plan?

@tychobrailleur
Copy link
Collaborator

in this repository (akasolace) i would like to release a stable 7.2 with modified update links to the new place. what do you think about this plan?

Yes, that makes sense.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Aug 22, 2023

as mentioned in #1849, we could do the move of this repository to the new place now (ho-dev if that repo is still a good choice as move target or new repo: hattrick-organizer)

After the move, we should recreate in akasolace/HO all the stuff that is required to lead old HO versions to the new place

  • releases that will do their next update with the new place
  • links of the existing installations (changelog e.g.)

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Aug 28, 2023

@tychobrailleur created a new github organization as possible target for the move

@tychobrailleur
Copy link
Collaborator

@tychobrailleur created a new github organization as possible target for the move

Great! You didn't like https://github.com/ho-dev/ ? :-)

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Aug 30, 2023

Great! You didn't like https://github.com/ho-dev/ ? :-)

I think we should retry a transfer of the repository. If we invoke the github transfer i would hope that issues and pull request will be included.

I don't care if it's called ho-dev or hattrick organizer. So feel free if you will remove the ho-dev repo and restart a transfer or use the new organization. I don't know if we can use anything from the other things in ho-dev?

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Sep 2, 2023

@tychobrailleur do you have admin rights on akasolace/ho. if so, you could invoke the transfer.

i don't see the settings option (anymore).

@tychobrailleur
Copy link
Collaborator

@tychobrailleur do you have admin rights on akasolace/ho. if so, you could invoke the transfer.

I don't, that's why I had to push code manually to ho-dev

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Sep 3, 2023

then we should ask @akasolace to transfer the ho repository.

@akasolace
Copy link
Collaborator

Hello, I will have a look now to move the code to ho-dev

@akasolace
Copy link
Collaborator

ok, so it seems it worked !

@tychobrailleur
Copy link
Collaborator

ok, so it seems it worked !

Wow, it also seems to have moved stars and forks, that's amazing! Thanks a lot for supporting, @akasolace

@akasolace
Copy link
Collaborator

ok, so it seems it worked !

Wow, it also seems to have moved stars and forks, that's amazing! Thanks a lot for supporting, @akasolace

I just had to push a button :/) Thank you @tychobrailleur and @wsbrenk for keeping the project alive !

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Sep 6, 2023

@tychobrailleur the old beta finds the new version. redirection is working perfectly.

image

@wsbrenk wsbrenk modified the milestones: 8.0, 7.3 Sep 6, 2023
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Sep 6, 2023
@wsbrenk wsbrenk closed this as completed Sep 9, 2023
wsbrenk added a commit to wsbrenk/HO that referenced this issue Sep 24, 2023
wsbrenk added a commit that referenced this issue Sep 24, 2023
* #1736 release_notes.md

* release stable 7.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

3 participants