Feat(Dashboard): add multiple products in main dashboard #219
Conversation
| [ProducesResponseType(typeof(ProductDto), StatusCodes.Status201Created)] | ||
| public async Task<ActionResult<ProductsDto>> AddProducts([FromBody] AddMultipleProductDto body) | ||
| { | ||
| var loggedInUserId = HttpContext.User.FindFirst(ClaimTypes.Sid).Value; |
There was a problem hiding this comment.
There is a service that already does this. Check the AuthenticationService in Infrastructure. You should move whatever logic you want to perform with this to the handler. Keep this controller simple.
| public class AddProductsCommand : IRequest<ProductsDto> | ||
| { | ||
| public AddProductsCommand(string userId, List<ProductCreationDto> productCreation) | ||
| { |
There was a problem hiding this comment.
This command is for adding Product, it has no business taking userId as a parameter/argument. If you want to assign a user to a product. Do it in the handler.
Godhanded
changed the title
| { | ||
| public class AddProductsCommand : IRequest<ProductsDto> | ||
| { | ||
| public AddProductsCommand(string userId, List<ProductCreationDto> productCreation) |
There was a problem hiding this comment.
don't collect the userId from the request, use the getloggedinuserId function in authentication service class in hng.infrastructure
| { | ||
| var product = _mapper.Map<Product>(item); | ||
| product.Id = Guid.NewGuid(); | ||
| product.UserId = Guid.Parse(request.UserId); |
There was a problem hiding this comment.
use the GetLoggedInUserId function in hng.infrastructure/services/authenticationservice to get the id of the user
|
Another branch created |
Description
Closes #218
Changes proposed
What were you told to do?
I added endpoint to add multiple products
Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Screenshots/Videos