Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want to remove undefined on tooltips & addressing overlaps between drivers #85

Open
vstevensf opened this issue Feb 24, 2023 · 3 comments

Comments

@vstevensf
Copy link
Collaborator

If a driver file does not include one of the optional attributes (according to documentation), the display shows "undefined", rather than a blank. More of a style issue, but of note if the user doesn't want "undefined" displayed. Otherwise, the user must include these attributes (columns) explicitly within a given driver file, with blank/empty values.

Screen Shot 2023-02-24 at 10 43 53 AM

@vstevensf
Copy link
Collaborator Author

Here is an example where, if all columns (including optional) are filled in, even with a blank, there will be no "undefined" value in the tooltip when hovering over a driver
Screen Shot 2023-02-28 at 11 33 57 AM

@vstevensf
Copy link
Collaborator Author

Lastly, whenever there are driver mutations close to one another (or in very rare cases, basically the same position), there is high overlap and one isn't able to accurately use the tooltip in the circular view to view metadata. Would be helpful in these cases to include the name of the gene in question in the tooltip (redundant but useful), or handle the overlap in a different manner that may not necessitate the user to zoom in within the linear view. Image below :)
Screen Shot 2023-02-28 at 11 43 35 AM

@sehilyi
Copy link
Member

sehilyi commented Mar 19, 2023

Issues from the first two comments are addressed in the latest commit (a24dd36).

Regarding the last comment about the visual overlaps, perhaps we can spread out the near-by genes to address the overlaps.

@sehilyi sehilyi changed the title Drivers display Want to remove undefined on tooltips & addressing overlaps between drivers Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants