Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks for samples #31

Open
Tracked by #26
thomcsmits opened this issue Sep 10, 2024 · 1 comment
Open
Tracked by #26

Hyperlinks for samples #31

thomcsmits opened this issue Sep 10, 2024 · 1 comment

Comments

@thomcsmits
Copy link
Collaborator

thomcsmits commented Sep 10, 2024

Add the option to add hyperlinks for samples to i.e., HuBMAP Data Portal datasets.

Would work better if the sample information is not a hover, but a click for expanding window.

@NickAkhmetov
Copy link
Collaborator

NickAkhmetov commented Sep 18, 2024

Perhaps we could enable this on a more generic level by allowing createRowHref and createColHref functions to be provided to the component? This would avoid specifically tying this to HuBMAP and enable more configurability for users.

e.g. for the HuBMAP datasets case, we would be able to pass in

createRowHref={(row) => `https://www.portal.hubmapconsortium.org/browse/datasets/${row}`}

We'd be able to pass in a similar function to link to cell types' ontology definitions:

createColumnHref={(col) => `https://www.ebi.ac.uk/ols4/search?q=${col}&ontology=cl`}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants