From fd56e0048bbef1175dd4054e703de7f1d2d43d80 Mon Sep 17 00:00:00 2001 From: Kian Kwa Date: Tue, 16 Jan 2024 15:05:12 +0000 Subject: [PATCH 1/2] Removed bi-lingual language for publications --- build.gradle | 2 +- .../services/service/PersonalisationServiceTest.java | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/build.gradle b/build.gradle index 7ad12143b..9181a1cc0 100644 --- a/build.gradle +++ b/build.gradle @@ -165,7 +165,7 @@ dependencies { implementation group: 'net.logstash.logback', name: 'logstash-logback-encoder', version: '7.4' implementation group: 'uk.gov.service.notify', name: 'notifications-java-client', version: '4.1.1-RELEASE' - implementation group: 'com.github.hmcts', name: 'pip-data-models', version: '2.1.14', { + implementation group: 'com.github.hmcts', name: 'pip-data-models', version: '2.1.17', { exclude group: 'org.springframework.boot', module: 'spring-boot-starter-data-jpa' } diff --git a/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java b/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java index fd026ce05..4e73a8cff 100644 --- a/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java +++ b/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java @@ -377,14 +377,13 @@ void buildRawDataNonSjpEnglishWhenAllPresent() { assertNotNull(contentDate, CONTENT_DATE_ASSERT_MESSAGE); } - @ParameterizedTest - @EnumSource(value = Language.class, names = {"WELSH", "BI_LINGUAL"}) - void buildRawDataNonSjpNonEnglishWhenAllPresent(Language language) { + @Test + void buildRawDataNonSjpWelshWhenAllPresent(Language language) { Artefact artefact = new Artefact(); artefact.setArtefactId(UUID.randomUUID()); artefact.setContentDate(LocalDateTime.now()); artefact.setListType(ListType.COP_DAILY_CAUSE_LIST); - artefact.setLanguage(language); + artefact.setLanguage(Language.WELSH); when(dataManagementService.getLocation(LOCATION_ID)).thenReturn(location); when(channelManagementService.getArtefactSummary(any())).thenReturn(HELLO); From 77bdc4d30af6117f4e617dfc662f4a5f1c01f484 Mon Sep 17 00:00:00 2001 From: Kian Kwa Date: Tue, 16 Jan 2024 15:52:44 +0000 Subject: [PATCH 2/2] Fixed failing test --- .../services/service/PersonalisationServiceTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java b/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java index 4e73a8cff..abdffdf14 100644 --- a/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java +++ b/src/test/java/uk/gov/hmcts/reform/pip/publication/services/service/PersonalisationServiceTest.java @@ -378,7 +378,7 @@ void buildRawDataNonSjpEnglishWhenAllPresent() { } @Test - void buildRawDataNonSjpWelshWhenAllPresent(Language language) { + void buildRawDataNonSjpWelshWhenAllPresent() { Artefact artefact = new Artefact(); artefact.setArtefactId(UUID.randomUUID()); artefact.setContentDate(LocalDateTime.now());