Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] failed for users with dot #20

Closed
zhilyaev opened this issue Aug 2, 2023 · 3 comments
Closed

[bug] failed for users with dot #20

zhilyaev opened this issue Aug 2, 2023 · 3 comments
Assignees
@hmarr

Comments

@zhilyaev
Copy link

zhilyaev commented Aug 2, 2023

Correct

*.go @user
*.go @zhilyaev

Not Correct.

*.go @firstname.lastname
*.go @dmitrii.zhiliaev

invalid owner format '@dmitrii.zhiliaev' at position 6
@zhilyaev
Copy link
Author

zhilyaev commented Aug 2, 2023

links with #13

@yuliazarkh
Copy link

yuliazarkh commented Aug 22, 2023 •
edited
Loading

Same error with username with undescore.
Example:
*.go @firstname_lastname

@hmarr hmarr self-assigned this Nov 26, 2023
@rwese rwese mentioned this issue May 31, 2024
Closed
@hmarr
Copy link
Owner

hmarr commented Jun 25, 2024

Now that #19 is merged, this is possible using a custom OwnerMatcher. If there's demand for a built-in set of GitLab owner matchers, I'd happily accept a PR.

@hmarr hmarr closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmarr hmarr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hmarr @zhilyaev @yuliazarkh