Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not show correct results for file path including leading ./ #17

Open
jeffgran-dox opened this issue Mar 23, 2023 · 3 comments
Open

Comments

@jeffgran-dox
Copy link

Title says it all.

If you run codeowners ./src/file.go it will always hit a * rule, or just (unowned) if there is no * rule.

Whereas codeowners src/file.go will correctly match a rule that covers this file/directory.

@jhaxon
Copy link

jhaxon commented Feb 23, 2024

I'm seeing this too.
First rule in my CODEOWNERS is a * rule.
Succeeding rules have more specific rules and override the first rule.

@rwese
Copy link

rwese commented May 31, 2024

from the docs

Order is important; the last matching pattern takes the most
precedence. When someone opens a pull request that only
modifies JS files, only @js-owner and not the global
owner(s) will be requested for a review.

I will take a stab at this

@rwese
Copy link

rwese commented May 31, 2024

There is an issue with how * and /... paths are handled.

Fixing the * is easy, but I need to readup on the path handling for gitignores to not break the intended compatibility, since I assume there is a reason for the current solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants