-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service architecture and networking redesign #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gisnav services, not other services
…v-compose Debian package
…pped and only remove them when the package is removed
Copies over ROS package source code so that the .deb package can build the gisnav image on its own. Makes the package independent of any external container registry. Disables running px4 service by default (introduces docker-compose.companion.yaml override) as it is not intended to be run on the companion computer where gisnav-compose is intended to be installed. Makes postrm script more robust to missing files, missing commands etc.
Includes dummy docs folder and vitepress/package.json to ensure gisnav image Dockerfile script goes through. Uses .gitignore to ensure rsync does not copy over unintended files to the Debian package
…rted with VO This ensures we can use VO even when no global matches have yet arrived. Also helps with debugging when gisnav_map and gisnav_odom are initialized to match the FCU (MAVROS) published equivalents
Paves way for significantly improving performance by (1) sharing keypoints for query image between LightGlue and visual odometry, and by (2) caching rotation independent SIFT keypoints for map tiles (DISK is not rotation independent)
This enables supporting cached precomputed keypoints and descriptors for reference maps later
This change needed because ORB features were swapped for SIFT features
Earlier the recomputation would be triggered if a new OrthoImage message was received even if the new map was the same as the old one
…d reference raster from updating with camera field of view movement
Ideally model parameters would be adjusted dynamically based on detected matching speed at runtime regardless of CPU/GPU
System is developed and tested on Raspberry Pi 5 but recommend Jetson Orin Nano instead even though not tested on that board. Performance much better using GPU
hmakelin
changed the title
Service architecture redesign
Service architecture and networking redesign
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnc
to simplify management of services. The tool is a wrapper arounddocker compose
that removes the need to pick the right combination of Compose overrides on supported platforms.MultiThreadedExecutor
to remove the bottleneck of running deep matching and shallow matching (VO) on the same CPU core if running on CPU (e.g. Raspberry Pi).