-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove thrift binary from Dockerfile? #11
Comments
Added a development Dockerfile containing thrift to the concrete repo: https://github.com/hltcoe/concrete/blob/main/Dockerfile |
ccmaymay
changed the title
Remove standalone thrift installation from Dockerfile?
Remove thrift binary from Dockerfile?
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Accelerated thrift should be installed by pip at this point. If we want the thrift binary in a container for rebuilding the concrete source, it might make more sense to have a separate Dockerfile for that (like a "runtime" Dockerfile and a "development" Dockerfile).
c.f. analogous issue in concrete-js hltcoe/concrete-js#9
The text was updated successfully, but these errors were encountered: