Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Active Directory "aud" JWT parameter is ignored #137

Open
ivan-zaitsev opened this issue Aug 9, 2022 · 1 comment
Open

Azure Active Directory "aud" JWT parameter is ignored #137

ivan-zaitsev opened this issue Aug 9, 2022 · 1 comment

Comments

@ivan-zaitsev
Copy link

ivan-zaitsev commented Aug 9, 2022

Current implementation of plugin is not validating "aud" parameter from JWT token. Because of this it is possible to login from any Azure Active Directory "App registration" even if specified "Client ID" belongs to different "App registration".

It would be good to validate audience parameter from JWT token with "Client ID" from configuration for security reasons.

@srvrguy
Copy link
Collaborator

srvrguy commented Aug 9, 2022

That's in the works. I'm moving the plugin away from the old ADAL4J library to the Nimbus OAuth 2.0 SDK. I would have used MSAL, but kept experiencing massive errors in trying to use it. Token validation is planned as part of this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants