Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEOPLE: Data quality in TableDisplay #834

Merged
merged 4 commits into from
Aug 21, 2024
Merged

PEOPLE: Data quality in TableDisplay #834

merged 4 commits into from
Aug 21, 2024

Conversation

hunchr
Copy link
Contributor

@hunchr hunchr commented Aug 14, 2024 •
edited
Loading

Fixes #792

image

@hunchr hunchr self-assigned this Aug 14, 2024
@hunchr hunchr force-pushed the feature/791-people-data-quality branch from 46541f1 to 07cc408 Compare August 14, 2024 13:53
@hunchr hunchr linked an issue Aug 14, 2024 that may be closed by this pull request
PEOPLE: Datenqualität als Spalte in Personenliste #792
Closed
3 tasks
@hunchr hunchr force-pushed the feature/792-people-data-quality branch from b94e838 to 7880db2 Compare August 14, 2024 13:56
@hunchr hunchr force-pushed the feature/791-people-data-quality branch 3 times, most recently from 0108f0d to 3b5b448 Compare August 15, 2024 12:46
Base automatically changed from feature/791-people-data-quality to master August 15, 2024 14:01
@hunchr hunchr force-pushed the feature/792-people-data-quality branch 5 times, most recently from 58a00e7 to 3df112c Compare August 19, 2024 06:43
@hunchr hunchr marked this pull request as ready for review August 19, 2024 06:44
@hunchr hunchr force-pushed the feature/792-people-data-quality branch from b3b64f7 to f065ffc Compare August 19, 2024 07:42
@hunchr hunchr mentioned this pull request Aug 19, 2024
Merged
@hunchr hunchr force-pushed the feature/792-people-data-quality branch 3 times, most recently from b2bd956 to 80b2a84 Compare August 21, 2024 06:48
@hunchr hunchr changed the title PEOPLE: Datenqualität in TableDisplay PEOPLE: Data quality in TableDisplay Aug 21, 2024
@hunchr hunchr force-pushed the feature/792-people-data-quality branch 2 times, most recently from 5b13700 to 6841a01 Compare August 21, 2024 12:31
@hunchr hunchr requested a review from njaeggi August 21, 2024 12:40
njaeggi
njaeggi requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@njaeggi njaeggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small suggestions

app/helpers/sac_cas/people_helper.rb Outdated Show resolved Hide resolved
spec/features/people/list_spec.rb Show resolved Hide resolved
@hunchr hunchr force-pushed the feature/792-people-data-quality branch from add9539 to cd5ff6f Compare August 21, 2024 13:20
@hunchr hunchr requested a review from njaeggi August 21, 2024 13:20
njaeggi
njaeggi approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@njaeggi njaeggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@njaeggi njaeggi force-pushed the feature/792-people-data-quality branch from cd5ff6f to 52b298d Compare August 21, 2024 14:05
@njaeggi njaeggi merged commit c6e2337 into master Aug 21, 2024
9 checks passed
@njaeggi njaeggi deleted the feature/792-people-data-quality branch August 21, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njaeggi njaeggi njaeggi approved these changes

Assignees

@hunchr hunchr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEOPLE: Datenqualität als Spalte in Personenliste
2 participants
@hunchr @njaeggi