Implement pr feedback

hitobito · Aug 21, 2024 · add9539 · add9539
1 parent 6841a01
commit add9539
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/app/helpers/sac_cas/people_helper.rb b/app/helpers/sac_cas/people_helper.rb
@@ -56,6 +56,7 @@ def format_data_quality_icons(status)
       warning: "exclamation-triangle",
       error: "times-circle"
     }
-    icon(icons[status.to_sym], title: I18n.t("people.data_quality.#{status}"))
+    icon_name = icons[status.to_sym]
+    icon(icon_name, title: I18n.t("people.data_quality.#{status}"))
   end
 end
diff --git a/spec/features/people/list_spec.rb b/spec/features/people/list_spec.rb
@@ -69,10 +69,17 @@
   end
 
   it "allows showing the data_quality column" do
+    group.people.first.update! data_quality: "info"
+    group.people.second.update! data_quality: "warning"
+    group.people.third.update! data_quality: "error"
+
     visit group_people_path(group_id: group.id)
     click_link("Spalten")
     check("Datenqualität")
-    click_link("Spalten")
-    expect(page).to have_css('td[data-attribute-name="data_quality"]')
+
+    expect(page).to have_css('td[data-attribute-name=data_quality] .fas.fa-check-circle')
+    expect(page).to have_css('td[data-attribute-name=data_quality] .fas.fa-info-circle')
+    expect(page).to have_css('td[data-attribute-name=data_quality] .fas.fa-exclamation-triangle')
+    expect(page).to have_css('td[data-attribute-name=data_quality] .fas.fa-times-circle')
   end
 end