Use ATTRIBUTES_TO_CHECK

hitobito · Aug 22, 2024 · 063b2a5 · 063b2a5
1 parent 1e68646
commit 063b2a5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/models/person/data_quality_issue.rb b/app/models/person/data_quality_issue.rb
@@ -23,8 +23,6 @@
 #  index_person_data_quality_issues_on_person_and_attribute_and_key (key) UNIQUE
 
 class Person::DataQualityIssue < ApplicationRecord
-  VALID_ATTRIBUTES = Person.column_names + ["phone_numbers"]
-
   belongs_to :person
 
   enum severity: {info: 1, warning: 2, error: 3}
@@ -48,6 +46,8 @@ def message
   private
 
   def person_attribute_exists
-    errors.add(:attr, :invalid) unless VALID_ATTRIBUTES.include?(attr)
+    return unless People::DataQualityChecker::ATTRIBUTES_TO_CHECK.include?(attr)
+
+    errors.add(:attr, :invalid)
   end
 end