Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect extension installation automatically and prompt for authentication #98

Open
markmhendrickson opened this issue Apr 1, 2021 · 9 comments
Labels

Comments

@markmhendrickson
Copy link
Contributor

Instead of requiring a manual refresh of the app upon installing the extension, we should automatically detect installation and prompt the user to proceed with authentication, either in the introductory modal or by opening the extension automatically as possible.

Current screen

image

@markmhendrickson
Copy link
Contributor Author

@aulneau @hstove do you know if automatic detection and opening of the extension here is possible upon return to the app's window? Or would @jasperjansz have to design some sort of updated state here where the user manually clicks to proceed to authentication with the newly installed extension?

@jasperjansz
Copy link

potentially related: https://docs.metamask.io/guide/onboarding-library.html#getting-started

@markmhendrickson markmhendrickson added this to the Improve onboarding milestone Apr 13, 2021
@fbwoolf fbwoolf self-assigned this Jun 9, 2021
@fbwoolf
Copy link
Contributor

fbwoolf commented Jun 10, 2021

Right now, after install the full page tab opens for the wallet so a user can go thru auth, do we want to change that so it redirects back to the app and launches a popup to authenticate instead?

@fbwoolf
Copy link
Contributor

fbwoolf commented Jun 10, 2021

I did not experience any different behavior than what we have now when I did the same process with Uniswap and MetaMask. Uniswap told me to install, I did, after install their full page tab was launched, I went back to Uniswap and had to manually close their modal and refresh before it detected I had installed MetaMask.

@fbwoolf
Copy link
Contributor

fbwoolf commented Jun 10, 2021

I think what we would want to do here is just close the modal once they have clicked on the download button ...and then in the web wallet extension reload the app page once it is installed and trigger the popup to go thru authentication?

@jasperjansz
Copy link

@fbwoolf related issue that can actually be implemented: https://github.com/blockstack/stacks-wallet-web/issues/1275

@fbwoolf
Copy link
Contributor

fbwoolf commented Jun 11, 2021

@jasperjansz great, thanks! I can assign myself to that one too and maybe it can close both.

@fbwoolf fbwoolf linked a pull request Jun 16, 2021 that will close this issue
9 tasks
@fbwoolf fbwoolf removed their assignment Jun 21, 2021
@fbwoolf fbwoolf removed a link to a pull request Jun 21, 2021
9 tasks
@markmhendrickson
Copy link
Contributor Author

@fbwoolf I believe you resolved this with #148 already, correct?

@fbwoolf
Copy link
Contributor

fbwoolf commented Jul 22, 2021

@fbwoolf I believe you resolved this with #148 already, correct?

My work on this was never merged. It is still in draft status. We decided to include it with the future onboarding refactor.

@smcclellan smcclellan removed this from the Improve onboarding milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants