Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: allow matching with regex for stacks print_event #379

Closed
wants to merge 3 commits into from

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Aug 11, 2023

Description

This PR introduces the ability to match on a print_event's values with a regex string rather than just with the previous contains field.

After working on this, I realized there was another way (albeit a kind of clunky way) of doing this without breaking the API. See #380.

Breaking change?

This breaks predicate registration for the if_this condition of stacks print_event predicates.

Previously:

{
  "scope" : "print_event",
  "contract_identifier": "*", 
  "contains": "vault"
}

Now:

{
  "scope" : "print_event",
  "contract_identifier": "*", 
  "matching_rule": { "contains": "vault" }
}

Checklist

  • All tests pass
  • Tests added in this PR (if applicable)

@lgalabru lgalabru deleted the regex-contains-print_event branch September 18, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant