Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUESTION] DQN Policy Kwargs depreciated? #888

Closed
ghost opened this issue Jun 11, 2020 · 5 comments
Closed

[QUESTION] DQN Policy Kwargs depreciated? #888

ghost opened this issue Jun 11, 2020 · 5 comments
Labels
more information needed Please fill the issue template completely question Further information is requested

Comments

@ghost
Copy link

ghost commented Jun 11, 2020 •
edited by ghost
Loading

SOLVED
@araffin araffin added the more information needed Please fill the issue template completely label Jun 11, 2020
@Miffyli Miffyli added the question Further information is requested label Jun 11, 2020
@Miffyli
Copy link
Collaborator

Miffyli commented Jun 11, 2020

I am not quite sure what is the problem. DQN does still accept policy_kwargs as before (although it seems to be missing from the docstring, wups), which is then passed on to the policy that is created. There was discussion on the confusion of how dueling architecture works (#587), however, so you have to be careful on what the different parameters will actually do to the network.

@araffin
Copy link
Collaborator

araffin commented Jun 11, 2020

my guess is replacing "net_arch" by "layers" should solve your issue ;) (cf dqn doc)

@ghost
Copy link
Author

ghost commented Jun 11, 2020

my guess is replacing "net_arch" by "layers" should solve your issue ;) (cf dqn doc)

Yes, but it just doesn't accept the policy_kwargs argument at all, so i can't input net_arch nor layers.

@ghost
Copy link
Author

ghost commented Jun 11, 2020

Sorry for semi wasting your time, it got solved by simply reinstalling Stable Baselines. Yes i was using the correct version of SB, somehow reinstalling solved the issue. Don't ask me how.. Sad time.

I'd like to end with that i appreciate the work you put in Stable Baselines, thanks!

@araffin araffin closed this as completed Jun 11, 2020
@ghost
Copy link
Author

ghost commented Jan 7, 2021

Please delete issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
more information needed Please fill the issue template completely question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Miffyli @araffin