Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/xray-connector-invalid-response #56

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

kamil-musialowski
Copy link
Contributor

@kamil-musialowski kamil-musialowski commented Nov 27, 2024

Fixed #54, response from xray converter was incorrect.

@kamil-musialowski kamil-musialowski self-assigned this Nov 27, 2024
@pawelfus pawelfus added this to the Next milestone Nov 28, 2024
@kamil-musialowski kamil-musialowski force-pushed the bugfix/xray-connector-invalid-response branch from 122730e to eb83551 Compare December 9, 2024 19:23
@kamil-musialowski
Copy link
Contributor Author

force push due to incorrect commit name, missing GlobalStockSector

@pawelfus pawelfus removed their request for review January 8, 2025 09:17
@kamil-musialowski kamil-musialowski marked this pull request as ready for review January 8, 2025 12:42
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

In addition to the inline comments, there is a bug when scrolling down in tables. Is this a bug in DataGrid (please report it then) or in the implementation (please fix it then)?

image

demos/dashboards-xray/demo.html Outdated Show resolved Hide resolved
demos/dashboards-xray/demo.js Outdated Show resolved Hide resolved
demos/dashboards-xray/demo.js Outdated Show resolved Hide resolved
demos/dashboards-xray/demo.js Outdated Show resolved Hide resolved
demos/dashboards-xray/demo.js Outdated Show resolved Hide resolved
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XRayConnector doesn't return valid response for Portfolio data points
3 participants