Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugins classpath differs between builds running with and without '--scan' #32

Closed
jjohannes opened this issue Dec 10, 2024 · 1 comment · Fixed by #77
Closed
Assignees
Milestone

Comments

@jjohannes
Copy link
Contributor

jjohannes commented Dec 10, 2024

This has the effect that many local build do not profit much from the remote build cache if they run without --scan

This issue is likely that --scan also auto-applies the com.gradle.develocity plugin and that that is happening before we apply it from inside org.hiero.gradle.build.

@jjohannes jjohannes self-assigned this Dec 10, 2024
@jjohannes jjohannes added this to the v0.2.0 milestone Dec 11, 2024
@jjohannes
Copy link
Contributor Author

jjohannes commented Jan 13, 2025

Confirmed. --scan is adding the plugin a second time before we add it. This alters the plugin classpath order, which invalidates caches:

There is no way to force --scan to not do this. The only option would be to apply the com.gradle:develocity-gradle-plugin plugin directly in every settings.gradle.kts file.

Therefore, instead of using --scan we will start using a custom build parameter -Pscan and print a warning if --scan is used: #77

We change the setup to always publish on CI and not use the --scan parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant