Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend formatting of .github/workflows/*.y(a)ml files #30

Open
jjohannes opened this issue Dec 9, 2024 · 2 comments
Open

Extend formatting of .github/workflows/*.y(a)ml files #30

jjohannes opened this issue Dec 9, 2024 · 2 comments
Assignees
Milestone

Comments

@jjohannes
Copy link
Contributor

jjohannes commented Dec 9, 2024

This is not completed yet. See comment:

/*
* Prettier requires NodeJS and NPM installed; however, the NodeJS Gradle plugin and Spotless do not yet
* integrate with each other. Currently there is an open issue report against spotless.
*
* *** Please see for more information: https://github.com/diffplug/spotless/issues/728 ***
*
* The workaround provided in the above issue does not work in Gradle 7.5+ and therefore is not a viable solution.
*/
// prettier()

Independent of that, it does not seem to run at all right now. The corresponding spotless tasks are UP-TO-DATE despite changes to the files.

@jjohannes jjohannes self-assigned this Dec 9, 2024
@jjohannes jjohannes added this to the v0.1.1 milestone Dec 10, 2024
@jjohannes
Copy link
Contributor Author

Problem is that some files have the extension yml and not yaml. 🤦

@jjohannes jjohannes changed the title Fix formatting of .github/workflows/*.yaml files Fix formatting of .github/workflows/*.y(a)ml files Dec 10, 2024
@jjohannes
Copy link
Contributor Author

Finding yml is fixed in 0.1.1.

Using prettier() will be added in a later release.

@jjohannes jjohannes modified the milestones: v0.1.1, v0.2.0 Dec 11, 2024
@jjohannes jjohannes changed the title Fix formatting of .github/workflows/*.y(a)ml files Extend formatting of .github/workflows/*.y(a)ml files Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant